fix tests for OptimizationSciPy

update location for IncompatibleOptimizerError

fix bug in error

Author: SebastianM-C

lib/OptimizationSciPy/src/OptimizationSciPy.jl

@@ -283,7 +283,7 @@ function SciMLBase.__init(prob::SciMLBase.OptimizationProblem, opt::ScipyOptimiz
     requires_bounds = opt isa Union{
         ScipyDifferentialEvolution, ScipyDirect, ScipyDualAnnealing, ScipyBrute}
     if requires_bounds && (isnothing(prob.lb) || isnothing(prob.ub))
-        throw(SciMLBase.IncompatibleOptimizerError("$(typeof(opt)) requires bounds"))
+        throw(OptimizationBase.IncompatibleOptimizerError("$(typeof(opt)) requires bounds"))
     end
     if opt isa ScipyMinimizeScalar && length(prob.u0) != 1
         throw(ArgumentError("ScipyMinimizeScalar requires exactly 1 variable, got $(length(prob.u0)). Use ScipyMinimize for multivariate problems."))

lib/OptimizationSciPy/test/runtests.jl

@@ -435,10 +435,10 @@ end
         @test sol.u ≈ [3.0] atol=1e-6
         optprob = OptimizationFunction(rosenbrock, OptimizationBase.AutoZygote())
         prob = OptimizationProblem(optprob, x0, _p)
-        @test_throws SciMLBase.IncompatibleOptimizerError solve(prob, ScipyDifferentialEvolution())
-        @test_throws SciMLBase.IncompatibleOptimizerError solve(prob, ScipyDirect())
-        @test_throws SciMLBase.IncompatibleOptimizerError solve(prob, ScipyDualAnnealing())
-        @test_throws SciMLBase.IncompatibleOptimizerError solve(prob, ScipyBrute())
+        @test_throws OptimizationBase.IncompatibleOptimizerError solve(prob, ScipyDifferentialEvolution())
+        @test_throws OptimizationBase.IncompatibleOptimizerError solve(prob, ScipyDirect())
+        @test_throws OptimizationBase.IncompatibleOptimizerError solve(prob, ScipyDualAnnealing())
+        @test_throws OptimizationBase.IncompatibleOptimizerError solve(prob, ScipyBrute())
         @test_throws ArgumentError solve(prob, ScipyBrent())
         @test_throws ArgumentError solve(prob, ScipyRootScalar("brentq"))
     end