Merge pull request #1008 from gabrevaya/fix_CMAEvolutionStrategy_sol_u

Fix CMAEvolutionStrategy solution `u`

Author: ChrisRackauckas

lib/OptimizationCMAEvolutionStrategy/src/OptimizationCMAEvolutionStrategy.jl

@@ -76,11 +76,11 @@ function SciMLBase.__solve(cache::OptimizationCache{
     local x, cur, state
 
     function _cb(opt, y, fvals, perm)
-        curr_u = opt.logger.xbest[end]
+        curr_u = xbest(opt)
         opt_state = Optimization.OptimizationState(; iter = length(opt.logger.fmedian),
             u = curr_u,
             p = cache.p,
-            objective = opt.logger.fbest[end],
+            objective = fbest(opt),
             original = opt.logger)
 
         cb_call = cache.callback(opt_state, x...)
@@ -112,8 +112,8 @@ function SciMLBase.__solve(cache::OptimizationCache{
         time = t1 - t0,
         fevals = length(opt_res.logger.fmedian))
     SciMLBase.build_solution(cache, cache.opt,
-        opt_res.logger.xbest[end],
-        opt_res.logger.fbest[end]; original = opt_res,
+        xbest(opt_res),
+        fbest(opt_res); original = opt_res,
         retcode = opt_ret,
         stats = stats)
 end

lib/OptimizationCMAEvolutionStrategy/test/runtests.jl

@@ -18,4 +18,5 @@ using Test
         return false
     end
     sol = solve(prob, CMAEvolutionStrategyOpt(), callback = cb, maxiters = 100)
-end
+    @test sol.u == OptimizationCMAEvolutionStrategy.CMAEvolutionStrategy.xbest(sol.original)
+end