Merge pull request #689 from AayushSabharwal/as/type-piracy

refactor: remove type-pirated functions

Author: ChrisRackauckas

Project.toml

@@ -16,7 +16,6 @@ ProgressLogging = "33c8b6b6-d38a-422a-b730-caa89a2f386c"
 Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
 SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
-SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
 TerminalLoggers = "5d786b92-1e48-4d6f-9151-6b4477ca9bed"
 
 [weakdeps]
@@ -57,10 +56,9 @@ Printf = "1.10"
 ProgressLogging = "0.1"
 Reexport = "1.2"
 ReverseDiff = "1.14"
-SciMLBase = "< 2.23.0"
+SciMLBase = "2.23.0"
 SparseArrays = "1.10"
 SparseDiffTools = "2.14"
-SymbolicIndexingInterface = "0.3.2"
 Symbolics = "5.12"
 TerminalLoggers = "0.1"
 Tracker = "0.2.29"

src/Optimization.jl

@@ -13,7 +13,6 @@ end
 
 using Logging, ProgressLogging, ConsoleProgressMonitor, TerminalLoggers, LoggingExtras
 using ArrayInterface, Base.Iterators, SparseArrays, LinearAlgebra
-using SymbolicIndexingInterface
 using Pkg
 
 import SciMLBase: OptimizationProblem,

src/cache.jl

@@ -1,40 +1,3 @@
-
-function Base.getproperty(cache::SciMLBase.AbstractOptimizationCache, x::Symbol)
-    if x in (:u0, :p)
-        return getfield(cache.reinit_cache, x)
-    end
-    return getfield(cache, x)
-end
-
-SciMLBase.has_reinit(cache::SciMLBase.AbstractOptimizationCache) = true
-function SciMLBase.reinit!(cache::SciMLBase.AbstractOptimizationCache; p = missing,
-        u0 = missing)
-    if p === missing && u0 === missing
-        p, u0 = cache.p, cache.u0
-    else # at least one of them has a value
-        if p === missing
-            p = cache.p
-        end
-        if u0 === missing
-            u0 = cache.u0
-        end
-        if (eltype(p) <: Pair && !isempty(p)) || (eltype(u0) <: Pair && !isempty(u0)) # one is a non-empty symbolic map
-            hasproperty(cache.f, :sys) && hasfield(typeof(cache.f.sys), :ps) ||
-                throw(ArgumentError("This cache does not support symbolic maps with `remake`, i.e. it does not have a symbolic origin." *
-                                    " Please use `remake` with the `p` keyword argument as a vector of values, paying attention to parameter order."))
-            hasproperty(cache.f, :sys) && hasfield(typeof(cache.f.sys), :states) ||
-                throw(ArgumentError("This cache does not support symbolic maps with `remake`, i.e. it does not have a symbolic origin." *
-                                    " Please use `remake` with the `u0` keyword argument as a vector of values, paying attention to state order."))
-            p, u0 = SciMLBase.process_p_u0_symbolic(cache, p, u0)
-        end
-    end
-
-    cache.reinit_cache.p = p
-    cache.reinit_cache.u0 = u0
-
-    return cache
-end
-
 struct OptimizationCache{F, RC, LB, UB, LC, UC, S, O, D, P, C} <:
        SciMLBase.AbstractOptimizationCache
     f::F