Skip to content

Commit ee9f9f9

Browse files
committed
comply with ode progress log
1 parent 89e2d0c commit ee9f9f9

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

Project.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
1212
LoggingExtras = "e6f89c97-d47a-5376-807f-9c37f3926c36"
1313
OptimizationBase = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
1414
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
15-
ProgressLogging = "33c8b6b6-d38a-422a-b730-caa89a2f386c"
1615
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
1716
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
1817
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
@@ -58,7 +57,6 @@ OptimizationOptimisers = "0.3"
5857
OrdinaryDiffEqTsit5 = "1"
5958
Pkg = "1"
6059
Printf = "1.10"
61-
ProgressLogging = "0.1"
6260
Random = "1.10"
6361
Reexport = "1.2"
6462
ReverseDiff = "1"
@@ -109,6 +107,6 @@ Mooncake = "da2b9cff-9c12-43a0-ae48-6db2b0edb7d6"
109107

110108
[targets]
111109
test = ["Aqua", "BenchmarkTools", "Boltz", "ComponentArrays", "DiffEqFlux", "Enzyme", "FiniteDiff", "Flux", "ForwardDiff",
112-
"Ipopt", "IterTools", "Lux", "MLUtils", "ModelingToolkit", "Optim", "OptimizationLBFGSB", "OptimizationMOI", "OptimizationOptimJL", "OptimizationOptimisers",
110+
"Ipopt", "IterTools", "Lux", "MLUtils", "ModelingToolkit", "Optim", "OptimizationLBFGSB", "OptimizationMOI", "OptimizationOptimJL", "OptimizationOptimisers",
113111
"OrdinaryDiffEqTsit5", "Pkg", "Random", "ReverseDiff", "SafeTestsets", "SciMLSensitivity", "SparseArrays",
114112
"Symbolics", "Test", "Tracker", "Zygote", "Mooncake"]

lib/OptimizationOptimisers/Project.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ authors = ["Vaibhav Dixit <[email protected]> and contributors"]
44
version = "0.3.12"
55
[deps]
66
OptimizationBase = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
7-
ProgressLogging = "33c8b6b6-d38a-422a-b730-caa89a2f386c"
87
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
98
Optimisers = "3bd65402-5787-11e9-1adc-39752487f4e2"
109
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
@@ -24,7 +23,6 @@ Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
2423
[compat]
2524
julia = "1.10"
2625
OptimizationBase = "3"
27-
ProgressLogging = "0.1"
2826
SciMLBase = "2.58"
2927
Optimisers = "0.2, 0.3, 0.4"
3028
Reexport = "1.2"

lib/OptimizationOptimisers/src/OptimizationOptimisers.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module OptimizationOptimisers
22

3-
using Reexport, ProgressLogging, UUIDs
3+
using Reexport, UUIDs
44
@reexport using Optimisers, OptimizationBase
55
using SciMLBase
66

@@ -134,9 +134,9 @@ function SciMLBase.__solve(cache::OptimizationBase.OptimizationCache{
134134
break
135135
end
136136
cache.progress &&
137-
@info ProgressLogging.Progress(progress_id, iterations / maxiters;
138-
name = "loss: $(round(first(first(x)); digits=3))")
139-
137+
@logmsg(LogLevel(-1), "Optimization";
138+
_id = progress_id, message = "Loss: $(round(first(first(x)); digits=3))",
139+
progress = iterations / maxiters)
140140
if cache.solver_args.save_best
141141
if first(x)[1] < first(min_err)[1] #found a better solution
142142
min_opt = opt
@@ -160,8 +160,8 @@ function SciMLBase.__solve(cache::OptimizationBase.OptimizationCache{
160160
end
161161
state, θ = Optimisers.update(state, θ, G)
162162
end
163-
164-
cache.progress && @info ProgressLogging.Progress(progress_id; done = true)
163+
cache.progress && @logmsg(LogLevel(-1), "Optimization";
164+
_id = progress_id, message = "Done", progress = 1.0)
165165
t1 = time()
166166
stats = OptimizationBase.OptimizationStats(; iterations,
167167
time = t1 - t0, fevals, gevals)

src/Optimization.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ if !isdefined(Base, :get_extension)
1111
using Requires
1212
end
1313

14-
using Logging, ProgressLogging, ConsoleProgressMonitor, TerminalLoggers, LoggingExtras
14+
using Logging, ConsoleProgressMonitor, TerminalLoggers, LoggingExtras
1515
using ArrayInterface, Base.Iterators, SparseArrays, LinearAlgebra
1616

1717
import OptimizationBase: instantiate_function, OptimizationCache, ReInitCache

0 commit comments

Comments
 (0)