Skip to content

Conversation

@mxpoch
Copy link
Contributor

@mxpoch mxpoch commented Jun 25, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I added the docs for the PyCMA wrapper as mentioned in #933. I noticed that the new Scipy wrappers allowed for passing python-specific kwargs so I added that functionality also.

@mxpoch
Copy link
Contributor Author

mxpoch commented Jun 25, 2025

Also, PyCMA does expose a 'termination_callback' option however I'm not familiar with what Optimization.jl expects for a callback. If somebody can let me know what the interface is I'd be happy to implement it.

@ChrisRackauckas
Copy link
Member

The callbacks are defined here https://docs.sciml.ai/Optimization/stable/API/solve/ where the callback function returns a bool which if true should halt the optimization.

@ChrisRackauckas ChrisRackauckas merged commit d62ff13 into SciML:master Jun 25, 2025
25 of 28 checks passed
@mxpoch mxpoch mentioned this pull request Jun 25, 2025
5 tasks
ChrisRackauckas pushed a commit that referenced this pull request Aug 1, 2025
Fixed 6 instances of unnecessary line splits across multiple files:
- src/auglag.jl: Fixed 1 complex mathematical expression with sum operations
- src/lbfgsb.jl: Fixed 1 identical complex mathematical expression
- lib/OptimizationMetaheuristics/src/OptimizationMetaheuristics.jl: Fixed 1 arithmetic expression for population_rand
- lib/OptimizationMetaheuristics/test/runtests.jl: Fixed 2 mathematical expressions in rosenbrock function
- lib/OptimizationNLPModels/test/runtests.jl: Fixed 1 mathematical expression in brown_dennis function
- lib/OptimizationMOI/test/runtests.jl: Fixed 1 arithmetic expression in OptimizationSystem

All changes follow Catalyst.jl PR #1306 guidelines to improve readability
by keeping semantically related expressions on single lines while staying
under 120 character limits.

Related to: JuliaFormatter.jl PR #934

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants