From 8f5778683a82950e4a4602feb4418fb1663ccb8c Mon Sep 17 00:00:00 2001 From: Vaibhav Kumar Dixit Date: Mon, 7 Apr 2025 11:51:37 -0400 Subject: [PATCH 1/2] Update OptimizationOptimJL.jl --- lib/OptimizationOptimJL/src/OptimizationOptimJL.jl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl index b2d6db4f8..7690f0e6c 100644 --- a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl +++ b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl @@ -38,12 +38,13 @@ function __map_optimizer_args(cache::OptimizationCache, abstol::Union{Number, Nothing} = nothing, reltol::Union{Number, Nothing} = nothing, kwargs...) - if !isnothing(abstol) - @warn "common abstol is currently not used by $(opt)" - end mapped_args = (; extended_trace = true, kwargs...) + if !isnothing(abstol) + mapped_args = (; mapped_args..., f_abstol = reltol) + end + if !isnothing(callback) mapped_args = (; mapped_args..., callback = callback) end @@ -72,7 +73,7 @@ function __map_optimizer_args(cache::OptimizationCache, end if !isnothing(reltol) - mapped_args = (; mapped_args..., f_tol = reltol) + mapped_args = (; mapped_args..., f_reltol = reltol) end return Optim.Options(; mapped_args...) From d9a1f195272d2dc322745c68a5d4e8008b7092d8 Mon Sep 17 00:00:00 2001 From: Vaibhav Kumar Dixit Date: Mon, 7 Apr 2025 15:04:58 -0400 Subject: [PATCH 2/2] Update lib/OptimizationOptimJL/src/OptimizationOptimJL.jl --- lib/OptimizationOptimJL/src/OptimizationOptimJL.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl index 7690f0e6c..24de50d31 100644 --- a/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl +++ b/lib/OptimizationOptimJL/src/OptimizationOptimJL.jl @@ -42,7 +42,7 @@ function __map_optimizer_args(cache::OptimizationCache, mapped_args = (; extended_trace = true, kwargs...) if !isnothing(abstol) - mapped_args = (; mapped_args..., f_abstol = reltol) + mapped_args = (; mapped_args..., f_abstol = abstol) end if !isnothing(callback)