Broken tests actually complete now

Author: Ickaser

lib/OrdinaryDiffEqBDF/test/dae_ad_tests.jl

@@ -30,15 +30,19 @@ prob_mm = ODEProblem(f_mm, u₀, tspan, p)
 
 # These tests flex differentiation of the solver and through the initialization
 # To only test the solver part and isolate potential issues, set the initialization to consistent
- @testset "Inplace: $(isinplace(_prob)), DAEProblem: $(_prob isa DAEProblem), BrownBasic: $(initalg isa BrownFullBasicInit), Autodiff: $autodiff" for _prob in [
+@testset "Inplace: $(isinplace(_prob)), DAEProblem: $(_prob isa DAEProblem), BrownBasic: $(initalg isa BrownFullBasicInit), Autodiff: $autodiff" for _prob in [
         prob, prob_oop, prob_mm],
     initalg in [BrownFullBasicInit(), ShampineCollocationInit()], autodiff in [afd_cs3, AutoFiniteDiff()]
 
-    alg = _prob isa DAEProblem ? DFBDF(; autodiff) : FBDF(; autodiff)
+    alg = (_prob isa DAEProblem) ? DFBDF(; autodiff) : FBDF(; autodiff)
     function f(p)
         sol = solve(remake(_prob, p = p), alg, abstol = 1e-14,
             reltol = 1e-14, initializealg = initalg)
         sum(sol)
     end
-    @test ForwardDiff.gradient(f, [0.04, 3e7, 1e4])≈[0, 0, 0] atol=1e-8
+    if _prob isa DAEProblem
+        @test ForwardDiff.gradient(f, [0.04, 3e7, 1e4])≈[0, 0, 0] atol=1e-8
+    else
+        @test_broken ForwardDiff.gradient(f, [0.04, 3e7, 1e4])≈[0, 0, 0] atol=1e-8
+    end
 end

test/interface/mass_matrix_tests.jl

@@ -328,10 +328,11 @@ M = zeros(n * n) |> Diagonal
 M[1, 1] = true # zero mass matrix breaks rosenbrock
 f = ODEFunction{true, SciMLBase.AutoSpecialize}(dynamics!, mass_matrix = M)
 tspan = (0, 10.0)
+adalg = AutoForwardDiff(chunksize=n)
 prob = ODEProblem(f, x0, tspan)
 foop = ODEFunction{false, SciMLBase.AutoSpecialize}(dynamics, mass_matrix = M)
 proboop = ODEProblem(f, x0, tspan)
-sol = @inferred solve(prob, Rosenbrock23())
-sol = @inferred solve(prob, Rodas4(), initializealg = ShampineCollocationInit())
-sol = @inferred solve(proboop, Rodas5())
-sol = @inferred solve(proboop, Rodas4(), initializealg = ShampineCollocationInit())
+@test_broken sol = @inferred solve(prob, Rosenbrock23(autodiff=adalg))
+@test_broken sol = @inferred solve(prob, Rodas4(autodiff=adalg), initializealg = ShampineCollocationInit())
+@test_broken sol = @inferred solve(proboop, Rodas5())
+@test_broken sol = @inferred solve(proboop, Rodas4(), initializealg = ShampineCollocationInit())