Skip to content

Commit c532135

Browse files
committed
Remove JET as test dependency and move verbosity_jet tests to nopre group
- Remove JET from [compat], [extras], and [targets] in Project.toml - JET is added via Pkg.add("JET") in the sublibrary test file instead - Move ODEVerbosity JET tests from test/interface/verbosity_jet.jl to lib/OrdinaryDiffEqCore/test/jet.jl - Delete test/interface/verbosity_jet.jl - Remove verbosity_jet.jl include from test/runtests.jl 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent fd51d8a commit c532135

File tree

4 files changed

+96
-103
lines changed

4 files changed

+96
-103
lines changed

Project.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ FiniteDiff = "2.27"
123123
ForwardDiff = "0.10.38, 1"
124124
FunctionWrappersWrappers = "0.1.3"
125125
InteractiveUtils = "1.9"
126-
JET = "0.9.18, 0.11.0"
127126
JLArrays = "0.2"
128127
LineSearches = "7.4"
129128
LinearAlgebra = "1.9"
@@ -190,7 +189,6 @@ DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
190189
ElasticArrays = "fdbdab4c-e67f-52f5-8c3f-e7b388dad3d4"
191190
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
192191
IncompleteLU = "40713840-3770-5561-ab4c-a76e7d0d7895"
193-
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
194192
JLArrays = "27aeb0d3-9eb9-45fb-866b-73c2ecf80fcb"
195193
ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
196194
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
@@ -208,4 +206,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
208206
Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
209207

210208
[targets]
211-
test = ["ComponentArrays", "AlgebraicMultigrid", "IncompleteLU", "DiffEqCallbacks", "DifferentiationInterface", "DiffEqDevTools", "ExplicitImports", "ODEProblemLibrary", "ElasticArrays", "JET", "JLArrays", "Random", "SafeTestsets", "StructArrays", "Test", "Unitful", "Pkg", "NLsolve", "RecursiveFactorization", "SparseConnectivityTracer", "SparseMatrixColorings", "Statistics"]
209+
test = ["ComponentArrays", "AlgebraicMultigrid", "IncompleteLU", "DiffEqCallbacks", "DifferentiationInterface", "DiffEqDevTools", "ExplicitImports", "ODEProblemLibrary", "ElasticArrays", "JLArrays", "Random", "SafeTestsets", "StructArrays", "Test", "Unitful", "Pkg", "NLsolve", "RecursiveFactorization", "SparseConnectivityTracer", "SparseMatrixColorings", "Statistics"]

lib/OrdinaryDiffEqCore/test/jet.jl

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,105 @@ using Pkg
22
Pkg.add("JET")
33

44
import OrdinaryDiffEqCore
5+
using OrdinaryDiffEqCore: ODEVerbosity
6+
import OrdinaryDiffEqCore.SciMLLogging as SciMLLogging
57
using JET, Test
68

79
@testset "JET Tests" begin
810
@test test_package(
911
OrdinaryDiffEqCore, target_defined_modules = true, mode = :typo
1012
) === nothing broken = true
1113
end
14+
15+
@testset "JET Test ODEVerbosity Constructors" begin
16+
@testset "Default constructor" begin
17+
@test_opt ODEVerbosity()
18+
end
19+
20+
@testset "Preset constructors" begin
21+
@test_opt ODEVerbosity(SciMLLogging.None())
22+
@test_opt ODEVerbosity(SciMLLogging.Minimal())
23+
@test_opt ODEVerbosity(SciMLLogging.Standard())
24+
@test_opt ODEVerbosity(SciMLLogging.Detailed())
25+
@test_opt ODEVerbosity(SciMLLogging.All())
26+
end
27+
28+
@testset "Group-level keyword constructors" begin
29+
@test_opt ODEVerbosity(error_control = SciMLLogging.ErrorLevel())
30+
@test_opt ODEVerbosity(numerical = SciMLLogging.Silent())
31+
@test_opt ODEVerbosity(performance = SciMLLogging.InfoLevel())
32+
@test_opt ODEVerbosity(error_control = SciMLLogging.WarnLevel())
33+
@test_opt ODEVerbosity(numerical = SciMLLogging.WarnLevel())
34+
@test_opt ODEVerbosity(performance = SciMLLogging.Silent())
35+
end
36+
37+
@testset "Individual keyword arguments" begin
38+
@test_opt ODEVerbosity(dt_NaN = SciMLLogging.ErrorLevel())
39+
@test_opt ODEVerbosity(alg_switch = SciMLLogging.InfoLevel())
40+
@test_opt ODEVerbosity(shampine_dt = SciMLLogging.Silent())
41+
@test_opt ODEVerbosity(init_NaN = SciMLLogging.WarnLevel())
42+
end
43+
44+
@testset "Linear and nonlinear verbosity" begin
45+
@test_opt ODEVerbosity(linear_verbosity = SciMLLogging.Detailed())
46+
@test_opt ODEVerbosity(nonlinear_verbosity = SciMLLogging.Minimal())
47+
@test_opt ODEVerbosity(linear_verbosity = SciMLLogging.None())
48+
@test_opt ODEVerbosity(nonlinear_verbosity = SciMLLogging.All())
49+
@test_opt ODEVerbosity(
50+
linear_verbosity = SciMLLogging.Detailed(),
51+
nonlinear_verbosity = SciMLLogging.Minimal()
52+
)
53+
@test_opt ODEVerbosity(
54+
linear_verbosity = SciMLLogging.None(),
55+
nonlinear_verbosity = SciMLLogging.All()
56+
)
57+
end
58+
59+
@testset "Mixed group and individual settings" begin
60+
@test_opt ODEVerbosity(
61+
numerical = SciMLLogging.Silent(),
62+
shampine_dt = SciMLLogging.WarnLevel()
63+
)
64+
@test_opt ODEVerbosity(
65+
numerical = SciMLLogging.Silent(),
66+
shampine_dt = SciMLLogging.WarnLevel(),
67+
performance = SciMLLogging.InfoLevel()
68+
)
69+
@test_opt ODEVerbosity(
70+
error_control = SciMLLogging.WarnLevel(),
71+
dt_NaN = SciMLLogging.ErrorLevel()
72+
)
73+
end
74+
75+
@testset "Multiple group settings" begin
76+
@test_opt ODEVerbosity(
77+
error_control = SciMLLogging.ErrorLevel(),
78+
performance = SciMLLogging.InfoLevel(),
79+
numerical = SciMLLogging.Silent()
80+
)
81+
@test_opt ODEVerbosity(
82+
error_control = SciMLLogging.WarnLevel(),
83+
performance = SciMLLogging.Silent(),
84+
numerical = SciMLLogging.WarnLevel()
85+
)
86+
end
87+
88+
@testset "Complex mixed settings" begin
89+
@test_opt ODEVerbosity(
90+
error_control = SciMLLogging.WarnLevel(),
91+
performance = SciMLLogging.InfoLevel(),
92+
numerical = SciMLLogging.Silent(),
93+
linear_verbosity = SciMLLogging.Detailed(),
94+
nonlinear_verbosity = SciMLLogging.Minimal(),
95+
dt_NaN = SciMLLogging.ErrorLevel(),
96+
shampine_dt = SciMLLogging.WarnLevel()
97+
)
98+
@test_opt ODEVerbosity(
99+
error_control = SciMLLogging.ErrorLevel(),
100+
performance = SciMLLogging.Silent(),
101+
numerical = SciMLLogging.WarnLevel(),
102+
linear_verbosity = SciMLLogging.All(),
103+
nonlinear_verbosity = SciMLLogging.None()
104+
)
105+
end
106+
end

test/interface/verbosity_jet.jl

Lines changed: 0 additions & 99 deletions
This file was deleted.

test/runtests.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ end
104104
@time @safetestset "Units Tests" include("interface/units_tests.jl")
105105
@time @safetestset "Non-Full Diagonal Sparsity Tests" include("interface/nonfulldiagonal_sparse.jl")
106106
@time @safetestset "ODEVerbosity Tests" include("interface/verbosity.jl")
107-
@time @safetestset "ODEVerbosity JET Tests" include("interface/verbosity_jet.jl")
108107
end
109108

110109
if !is_APPVEYOR && (GROUP == "All" || GROUP == "InterfaceIV" || GROUP == "Interface")

0 commit comments

Comments
 (0)