feat: allow initialization of null integrators #2228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
AayushSabharwal
force-pushed
the
as/param-initprob
branch
from
1651ee6 to
a2cb472
Compare
|
What's a case that needs this? |
|
This was part of the rework that allows parameters to be unknowns in the initialization system. That bit is on hold for the time being, pending the discussion in SciML/ModelingToolkit.jl#2665 |
|
Don't you just need to add the initializationprob call up here? https://github.com/SciML/DiffEqBase.jl/blob/master/src/solve.jl#L678 |
|
Hmm yeah that does look better. I'll try that, thanks! |
|
Superseded by #2314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
remake_bufferModelingToolkit.jl#2729Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.