debug leftovers removed, throw errors explicitly , removed sparseArray test

Author: Lewih

src/array_partition.jl

@@ -372,16 +372,27 @@ function LinearAlgebra._swap_rows!(B::ArrayPartition, i::Integer, j::Integer)
 end
 
 # linalg mul! overloads for ArrayPartition
-function LinearAlgebra.mul!(C::T, A::T, B::AbstractArray) where T<:ArrayPartition
-    @assert length(C.x) == length(A.x)
+function LinearAlgebra.mul!(C::ArrayPartition, A::ArrayPartition, B::AbstractArray)
+    if length(C.x) != length(A.x)
+        throw(DimensionMismatch("Length of C, $(length(C.x)), does not match length of A, $(length(A.x))"))
+    end
+
     for index = 1:length(C.x)
         mul!(C.x[index], A.x[index], B)
     end
+    return C
 end
 
-function LinearAlgebra.mul!(C::T, A::T, B::T) where T<:ArrayPartition
-    @assert length(C.x) == length(A.x) == length(B.x)
+function LinearAlgebra.mul!(C::ArrayPartition, A::ArrayPartition, B::ArrayPartition)
+    if length(C.x) != length(A.x)
+        throw(DimensionMismatch("Length of C, $(length(C.x)), does not match length of A, $(length(B.x))"))
+    end
+    if length(A.x) != length(B.x)
+        throw(DimensionMismatch("Length of A, $(length(A.x)), does not match length of B, $(length(B.x))"))
+    end
+
     for index = 1:length(C.x)
         mul!(C.x[index], A.x[index], B.x[index])
     end
+    return C
 end

test/linalg.jl

@@ -1,5 +1,5 @@
 using RecursiveArrayTools, Test, Random
-using LinearAlgebra, SparseArrays
+using LinearAlgebra
 
 n, m = 5, 6
 bb = rand(n), rand(m)
@@ -36,7 +36,7 @@ b = ArrayPartition(bb)
 c = ArrayPartition(cc)
 d = ArrayPartition(dd)
 A = rand(n)
-for T in (Array{Float64}, Array{ComplexF64}, sparse, )
+for T in (Array{Float64}, Array{ComplexF64},)
     B = T(A)
     mul!(d, b, A)
     for i = 1:length(c.x)