Broaden vector eltype signature for push!

stillyslalom · web-flow · commit 89383b4933d0 · 2021-07-05T18:04:27.000-05:00
Pushing to `AbstractVectorOfArray` is currently limited to vectors with eltype `AbstractVector`, which seems likely to have been a too-restrictive oversight. This PR broadens the accepted eltype to `AbstractArray`.
diff --git a/src/vector_of_array.jl b/src/vector_of_array.jl
@@ -169,7 +169,7 @@ Base.copy(VA::AbstractDiffEqArray) = typeof(VA)(
   )
 Base.copy(VA::AbstractVectorOfArray) = typeof(VA)(copy(VA.u))
 Base.sizehint!(VA::AbstractVectorOfArray{T, N}, i) where {T, N} = sizehint!(VA.u, i)
-Base.push!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractVector) where {T, N} = push!(VA.u, new_item)
+Base.push!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractArray) where {T, N} = push!(VA.u, new_item)
 
 function Base.append!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractVectorOfArray{T, N}) where {T, N}
     for item in copy(new_item)

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ Base.copy(VA::AbstractDiffEqArray) = typeof(VA)(`
`169`	`169`	`)`
`170`	`170`	`Base.copy(VA::AbstractVectorOfArray) = typeof(VA)(copy(VA.u))`
`171`	`171`	`Base.sizehint!(VA::AbstractVectorOfArray{T, N}, i) where {T, N} = sizehint!(VA.u, i)`
`172`		`-Base.push!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractVector) where {T, N} = push!(VA.u, new_item)`
	`172`	`+Base.push!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractArray) where {T, N} = push!(VA.u, new_item)`
`173`	`173`
`174`	`174`	`function Base.append!(VA::AbstractVectorOfArray{T, N}, new_item::AbstractVectorOfArray{T, N}) where {T, N}`
`175`	`175`	`for item in copy(new_item)`