Merge pull request #287 from SciML/simplify-issymbollike

simplify issymbollike

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "RecursiveArrayTools"
 uuid = "731186ca-8d62-57ce-b412-fbd966d074cd"
 authors = ["Chris Rackauckas <[email protected]>"]
-version = "2.38.10"
+version = "2.39.0"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

src/vector_of_array.jl

@@ -64,17 +64,9 @@ end
 struct AllObserved
 end
 
-Base.@pure __parameterless_type(T) = Base.typename(T).wrapper
-
-@generated function issymbollike(x)
-    x <: Union{Symbol, AllObserved} && return quote true end
-    ss = ["Operation", "Variable", "Sym", "Num", "Term"]
-    s = string(Symbol(__parameterless_type(x)))
-    bool = any(x -> occursin(x, s), ss) 
-    quote 
-        $bool
-    end
-end
+# extended by Symbolcs
+issymbollike(::Any) = false
+issymbollike(::Union{Symbol, AllObserved}) = true
 
 function Base.Array(VA::AbstractVectorOfArray{T, N, A}) where {T, N,
                                                                A <: AbstractVector{
@@ -196,6 +188,7 @@ Base.@propagate_inbounds function Base.getindex(A::AbstractDiffEqArray{T, N},
     RecursiveArrayTools.VectorOfArray(A.u)[I...]
 end
 
+__parameterless_type(T) = Base.typename(T).wrapper
 Base.@propagate_inbounds function Base.getindex(A::AbstractVectorOfArray{T, N},
                                                 I::Colon...) where {T, N}
     @assert length(I) == ndims(A.u[1]) + 1