Merge pull request #770 from jClugstor/solution_strip_test

Fix solution stripping for ODESolution

Author: ChrisRackauckas

src/solutions/ode_solutions.jl

@@ -613,8 +613,7 @@ function strip_solution(sol::ODESolution)
 
     interp = strip_interpolation(sol.interp)
 
-    ODESolution(sol.u, sol.u_analytic, sol.errors,
-        sol.t, sol.k, sol.discretes, nothing, nothing,
-        interp, sol.dense, sol.tslocation, sol.stats,
-        sol.alg_choice, sol.retcode, sol.resid, sol.original)
+    @reset sol.interp = interp
+    @reset sol.prob = nothing
+    return @set sol.alg = nothing
 end

test/downstream/ode_stripping.jl

@@ -1,10 +1,23 @@
-using OrdinaryDiffEq
-f(u, p, t) = 1.01 * u
-u0 = 1 / 2
+using OrdinaryDiffEq, SciMLBase
+
+function lorenz!(du, u, p, t)
+    du[1] = 10.0 * (u[2] - u[1])
+    du[2] = u[1] * (28.0 - u[3]) - u[2]
+    du[3] = u[1] * u[2] - (8 / 3) * u[3]
+end
+
+u0 = [1.0; 0.0; 0.0]
 tspan = (0.0, 1.0)
-prob = ODEProblem(f, u0, tspan)
-sol = solve(prob, Tsit5(), reltol = 1e-8, abstol = 1e-8)
+prob = ODEProblem(lorenz!, u0, tspan)
+# implicit solver so we can test cache stripping worked
+sol = solve(prob, Rosenbrock23())
+
+@test isnothing(SciMLBase.strip_solution(sol).prob)
+
+@test isnothing(SciMLBase.strip_solution(sol).alg)
+
+@test isnothing(SciMLBase.strip_solution(sol).interp.f)
 
-@test isnothing(strip_solution(sol).f)
+@test isnothing(SciMLBase.strip_solution(sol).interp.cache.jac_config)
 
-@test isnothing(strip_solution(sol).interp.f)
+@test isnothing(SciMLBase.strip_solution(sol).interp.cache.grad_config)

test/runtests.jl

@@ -112,6 +112,9 @@ end
         @time @safetestset "Autodiff Observable Functions" begin
             include("downstream/observables_autodiff.jl")
         end
+        @time @safetestset "ODE Solution Stripping" begin
+            include("downstream/ode_stripping.jl")
+        end
     end
 
     if !is_APPVEYOR && (GROUP == "Downstream" || GROUP == "SymbolicIndexingInterface")