fix: fix type-stability of remake(::SCCNonlinearProblem) on julia@10

Author: AayushSabharwal

src/remake.jl

@@ -824,26 +824,38 @@ function scc_update_subproblems(probs::Vector, newu0, newp, parameters_alias)
     end
 end
 
-function scc_update_subproblems(probs::Tuple, newu0, newp, parameters_alias)
-    offset = Ref(0)
-    return ntuple(Val(length(probs))) do i
-        subprob = probs[i]
-        # N should be inferred if `prob` is type-stable and `subprob.u0 isa StaticArray`
-        N = length(state_values(subprob))
-        if ArrayInterface.ismutable(newu0)
-            _u0 = newu0[(offset[] + 1):(offset[] + N)]
-        else
-            _u0 = StaticArraysCore.similar_type(
-                newu0, StaticArraysCore.Size(N))(newu0[(offset[] + 1):(offset[] + N)])
-        end
-        subprob = if parameters_alias === Val(true)
-            remake(subprob; u0 = _u0, p = newp)
-        else
-            remake(subprob; u0 = _u0)
-        end
-        offset[] += N
-        return subprob
+@generated function scc_update_subproblems(probs::Tuple, newu0, newp, parameters_alias)
+    function get_expr(i::Int)
+        subprob_name = Symbol(:subprob, i)
+        quote
+            $subprob_name = probs[$i]
+            # N should be inferred if `prob` is type-stable and `subprob.u0 isa StaticArray`
+            N = length(state_values($subprob_name))
+            if ArrayInterface.ismutable(newu0)
+                _u0 = newu0[(offset + 1):(offset + N)]
+            else
+                _u0 = StaticArraysCore.similar_type(
+                    newu0, StaticArraysCore.Size(N))(newu0[(offset + 1):(offset + N)])
+            end
+            $subprob_name = if parameters_alias === Val(true)
+                remake($subprob_name; u0 = _u0, p = newp)
+            else
+                remake($subprob_name; u0 = _u0)
+            end
+            offset += N
+        end, subprob_name
+    end
+    expr = quote
+        offset = 0
     end
+    subprob_names = []
+    for i in 1:fieldcount(probs)
+        subexpr, spname = get_expr(i)
+        push!(expr.args, subexpr)
+        push!(subprob_names, spname)
+    end
+    push!(expr.args, Expr(:tuple, subprob_names...))
+    return expr
 end
 
 """
@@ -882,11 +894,9 @@ function remake(prob::SCCNonlinearProblem; u0 = missing, p = missing, probs = mi
     end
     f = coalesce(f, prob.f)
     f = remake(f; sys)
-    props = getproperties(f)
-    props = @delete props.f
 
-    return SCCNonlinearProblem(
-        probs, explicitfuns!, newp, parameters_alias; props...)
+    return SCCNonlinearProblem{typeof(probs), typeof(explicitfuns!), typeof(f), typeof(newp)}(
+        probs, explicitfuns!, f, newp, parameters_alias)
 end
 
 function varmap_has_var(varmap, var)