Fix up definition

Author: ChrisRackauckas

src/ODE_nlsolve.jl

@@ -9,16 +9,16 @@ struct ODE_NLProbData{NLProb, UNLProb, SetGammaC, SetOuterTmp, SetInnerTmp, NLPr
     implicit time discretizations. This allows to use extra structure of the ODE function (e.g.
     multi-level structure). The nonlinear function must match that form of the function implicit
     ODE integration algorithms need do solve the a nonlinear problems,
-    specifically of the form `z = outer_tmp + dt⋅f(γ⋅z+inner_tmp,p,t)`.
-    Here `z` is the stage solution vector, `p` is the parameter of the ODE problem, `t` is
-    the time, `dt` the respective time increment`, `γ` is some scaling factor and the temporary
+    specifically of the form `M*z = outer_tmp + γ⋅f(z+inner_tmp,p,t_c)`.
+    Here `z` is the stage solution vector, `p` is the parameter of the ODE problem, `t_c` is
+    the time of evaluation (`t_c = t + c*dt`), `γ` is some scaling factor and the temporary
     variables are some compatible vectors set by the specific solver.
     Note that this field will not be used for integrators such as fully-implicit Runge-Kutta methods
     that need to solve different nonlinear systems.
     The inner nonlinear function of the nonlinear problem is in general of the form `g(z,p') = 0`
     where `p'` is a NamedTuple with all information about the specific nonlinear problem at hand to solve
-    for a specific time discretization. Specifically, it is `(;dt, γ, inner_tmp, outer_tmp, t, p)`, such that
-    `g(z,p') = dt⋅f(γ⋅z+inner_tmp,p,t) + outer_tmp - z = 0`.
+    for a specific time discretization. Specifically, it is `(;γ, inner_tmp, outer_tmp, t_c, p)`, such that
+    `g(z,p') = γ⋅f(z+inner_tmp,p,t_c) + outer_tmp - M*z = 0`.
     """
     nlprob::NLProb
     """

src/scimlfunctions.jl

@@ -409,7 +409,7 @@ numerically-defined functions.
 """
 struct ODEFunction{iip, specialize, F, TMM, Ta, Tt, TJ, JVP, VJP, JP, SP, TW, TWt, WP, TPJ,
     O, TCV,
-    SYS, ID <: Union{Nothing, OverrideInitData}, NLP <: Union{Nothing, ODE_NLProbData}} <:
+    SYS, ID <: Union{Nothing, OverrideInitData}, NLP <: Union{Nothing, ODENLStepData}} <:
        AbstractODEFunction{iip}
     f::F
     mass_matrix::TMM
@@ -532,7 +532,7 @@ information on generating the SplitFunction from this symbolic engine.
 struct SplitFunction{
     iip, specialize, F1, F2, TMM, C, Ta, Tt, TJ, JVP, VJP, JP, WP, SP, TW, TWt,
     TPJ, O, TCV, SYS, ID <: Union{Nothing, OverrideInitData},
-    NLP <: Union{Nothing, ODE_NLProbData}} <: AbstractODEFunction{iip}
+    NLP <: Union{Nothing, ODENLStepData}} <: AbstractODEFunction{iip}
     f1::F1
     f2::F2
     mass_matrix::TMM
@@ -2749,7 +2749,7 @@ function ODEFunction{iip, specialize}(f;
             typeof(sparsity), Any, Any, typeof(W_prototype), Any,
             Any,
             typeof(_colorvec),
-            typeof(sys), Union{Nothing, OverrideInitData}, Union{Nothing, ODE_NLProbData}}(
+            typeof(sys), Union{Nothing, OverrideInitData}, Union{Nothing, ODENLStepData}}(
             _f, mass_matrix, analytic, tgrad, jac,
             jvp, vjp, jac_prototype, sparsity, Wfact,
             Wfact_t, W_prototype, paramjac,
@@ -2796,7 +2796,7 @@ function unwrapped_f(f::ODEFunction, newf = unwrapped_f(f.f))
             Any, Any, Any, Any, typeof(f.jac_prototype),
             typeof(f.sparsity), Any, Any, Any, Any,
             Any, typeof(f.colorvec),
-            typeof(f.sys), Union{Nothing, OverrideInitData}, Union{Nothing, ODE_NLProbData}}(
+            typeof(f.sys), Union{Nothing, OverrideInitData}, Union{Nothing, ODENLStepData}}(
             newf, f.mass_matrix, f.analytic, f.tgrad, f.jac,
             f.jvp, f.vjp, f.jac_prototype, f.sparsity, f.Wfact,
             f.Wfact_t, f.W_prototype, f.paramjac,
@@ -3021,7 +3021,7 @@ function SplitFunction{iip, specialize}(f1, f2;
     if specialize === NoSpecialize
         SplitFunction{iip, specialize, Any, Any, Any, Any, Any, Any, Any, Any, Any,
             Any, Any, Any, Any, Any, Any, Any,
-            Any, Any, Union{Nothing, OverrideInitData}, Union{Nothing, ODE_NLProbData}}(
+            Any, Any, Union{Nothing, OverrideInitData}, Union{Nothing, ODENLStepData}}(
             f1, f2, mass_matrix, _func_cache,
             analytic,
             tgrad, jac, jvp, vjp, jac_prototype, W_prototype,