fix: fix usage of SCCNonlinearProblem.parameters_alias as a boolean

Author: AayushSabharwal

src/problems/nonlinear_problems.jl

@@ -557,7 +557,7 @@ end
 function SymbolicIndexingInterface.set_parameter!(prob::SCCNonlinearProblem, val, idx)
     if prob.p !== nothing
         set_parameter!(prob.p, val, idx)
-        prob.parameters_alias && return
+        prob.parameters_alias === Val(true) && return
     end
     for scc in prob.probs
         is_parameter(scc, idx) || continue

src/remake.jl

@@ -861,7 +861,10 @@ override the values in `probs`. `sys` is the index provider for the full system.
 function remake(prob::SCCNonlinearProblem; u0 = missing, p = missing, probs = missing,
         parameters_alias = prob.parameters_alias, f = missing, sys = missing,
         interpret_symbolicmap = true, use_defaults = false, explicitfuns! = missing)
-    if p !== missing && !parameters_alias && probs === missing
+    if parameters_alias isa Bool
+        parameters_alias = Val(parameters_alias)
+    end
+    if p !== missing && parameters_alias === Val(false) && probs === missing
         throw(ArgumentError("`parameters_alias` is `false` for the given `SCCNonlinearProblem`. Please provide the subproblems using the keyword `probs` with the parameters updated appropriately in each."))
     end
     newu0, newp = updated_u0_p(prob, u0, p; interpret_symbolicmap, use_defaults)
@@ -874,7 +877,7 @@ function remake(prob::SCCNonlinearProblem; u0 = missing, p = missing, probs = mi
     if sys === missing
         sys = prob.f.sys
     end
-    if u0 !== missing || p !== missing && parameters_alias
+    if u0 !== missing || p !== missing && parameters_alias === Val(true)
         probs = scc_update_subproblems(probs, newu0, newp, parameters_alias)
     end
     f = coalesce(f, prob.f)

test/downstream/modelingtoolkit_remake.jl

@@ -330,7 +330,7 @@ end
     newp = remake_buffer(sccprob.f.sys, sccprob.p, [σ], [3.0])
     sccprob4 = remake(sccprob; parameters_alias = false, p = newp,
         probs = [remake(sccprob.probs[1]; p = deepcopy(newp)), sccprob.probs[2]])
-    @test !sccprob4.parameters_alias
+    @test sccprob4.parameters_alias === Val(false)
     @test sccprob4.p !== sccprob4.probs[1].p
     @test sccprob4.p !== sccprob4.probs[2].p
 end