add PreallocationTools.DiffCache as cache for SplitODEProblem #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we do the dependency decrease, we might as well just make it be a DualCache? |
|
This should be good. Add a test for it in the downstream section? |
thomvet
changed the title
Force more function specialization
ChrisRackauckas
approved these changes
Aug 13, 2025
|
Rebase |
…Base.jl into fix-orddiffeq-2719
make DiffCache instead of LBC add test slimmer using Update test/downstream/splitodeproblem_cache.jl Apply suggestions from code review Apply suggestions from code review slimmer using Update test/downstream/splitodeproblem_cache.jl Apply suggestions from code review
…Base.jl into fix-orddiffeq-2719
|
Apparently, I am too noob to rebase properly (sorry). Will redo the changes in a new PR instead. |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses SciML/OrdinaryDiffEq.jl#2719
Needs: SciML/PreallocationTools.jl#131 and SciML/DiffEqBase.jl#1188