refactor: use initialization_data instead of initializeprob, etc.
#838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is breaking to downstream though if the CheckInit and OverrideInit isn't also changed? |
Member
Author
|
I forgot to overload |
AayushSabharwal
force-pushed
the
as/initdata
branch
from
7c21992 to
70d7747
Compare
ChrisRackauckas
approved these changes
Oct 30, 2024
AayushSabharwal
force-pushed
the
as/initdata
branch
2 times, most recently
from
a067798 to
b4cce5b
Compare
The existing syntax is `initializeprob, ..., nlprob`. Trying to add `initialization_data` in the middle breaks the non-kwarg-only method. Putting it at the end fixes this issue. Anything old still has the order it relies on, with `initialization_data` defaulting to `nothing`, and anything new would just have to provide the redundant kwargs if it needs to specify `initialization_data`.
AayushSabharwal
force-pushed
the
as/initdata
branch
from
b4cce5b to
2804efb
Compare
ChrisRackauckas
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for moving
OverrideInitandCheckInitto SciMLBaseChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.