Skip to content

fix: fix some SciMLFunction constructors #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix: fix some SciMLFunction constructors #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd90c6
fix: fix some SciMLFunction constructors
AayushSabharwal Nov 8, 2024
b821d1e
refactor: format
AayushSabharwal Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/scimlfunctions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2853,7 +2853,7 @@ function DynamicalODEFunction{iip, specialize}(f1, f2;
colorvec = __has_colorvec(f1) ? f1.colorvec :
nothing,
sys = __has_sys(f1) ? f1.sys : nothing,
initialization_data = __has_initialization_data(f) ? f.initialization_data :
initialization_data = __has_initialization_data(f1) ? f1.initialization_data :
nothing) where {
iip,
specialize
Expand Down Expand Up @@ -3195,7 +3195,7 @@ function SplitSDEFunction{iip, specialize}(f1, f2, g;
colorvec = __has_colorvec(f1) ? f1.colorvec :
nothing,
sys = __has_sys(f1) ? f1.sys : nothing,
initialization_data = __has_initialization_data(f) ? f.initialization_data :
initialization_data = __has_initialization_data(f1) ? f1.initialization_data :
nothing) where {
iip,
specialize
Expand Down Expand Up @@ -3282,7 +3282,7 @@ function DynamicalSDEFunction{iip, specialize}(f1, f2, g;
colorvec = __has_colorvec(f1) ? f1.colorvec :
nothing,
sys = __has_sys(f1) ? f1.sys : nothing,
initialization_data = __has_initialization_data(f) ? f.initialization_data :
initialization_data = __has_initialization_data(f1) ? f1.initialization_data :
nothing
) where {
iip,
Expand Down
3 changes: 2 additions & 1 deletion test/downstream/problem_interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ prob = SteadyStateProblem(osys, u0, ps)
@test prob[X2] == prob[osys.X2] == prob[:X2] == 0.2
@test prob[[X, X2]] == prob[[osys.X, osys.X2]] == prob[[:X, :X2]] == [0.1, 0.2]
@test getsym(prob, X)(prob) == getsym(prob, osys.X)(prob) == getsym(prob, :X)(prob) == 0.1
@test getsym(prob, X2)(prob) == getsym(prob, osys.X2)(prob) == getsym(prob, :X2)(prob) == 0.2
@test getsym(prob, X2)(prob) == getsym(prob, osys.X2)(prob) == getsym(prob, :X2)(prob) ==
0.2
@test getsym(prob, [X, X2])(prob) == getsym(prob, [osys.X, osys.X2])(prob) ==
getsym(prob, [:X, :X2])(prob) == [0.1, 0.2]
@test getsym(prob, (X, X2))(prob) == getsym(prob, (osys.X, osys.X2))(prob) ==
Expand Down
Loading