-
-
Notifications
You must be signed in to change notification settings - Fork 113
CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Makie in [weakdeps] to 0.22, (keep existing compat) #905
Conversation
4416ca2 to
6473368
Compare
|
Gentle bump on this, it's preventing the latest Makie and OrdinaryDiffEq from working together, and if you have Makie as a direct dep in your project file, it ends up downgrading the SciML stack by quite a bit |
|
All SciMLBase tests pass locally for me, IMO this is mergeable (plus, there haven't been that many breaking changes to Makie this round) |
|
rerunning CI. Will merge if it looks decent. |
|
It looks like this is having some serious issues. |
|
Do you mean the Makie integration or the CI? I ran some basic examples locally and they seemed fine... |
|
I'm just looking at the CI runs which seem very unhappy. |
|
Dependency problems: |
|
bump, I'm not familiar with the test suite here but from looking at failures they don't seem related to Makie |
|
We're getting some precompilation errors now when using OrdinaryDiffEq together with [email protected]: See https://github.com/trixi-framework/TrixiParticles.jl/actions/runs/12950929491/job/36124805133?pr=705. |
|
That was a hiccup in ADTypes that is now fixed. |
This pull request changes the compat entry for the
Makiepackage from0.20, 0.21to0.20, 0.21, 0.22.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.