Skip to content

fix: handle :var => nothing provided to remake #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: handle :var => nothing provided to remake #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/remake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,7 @@ function fill_vars(
end
for (k, v) in varmap
haskey(sym_to_idx, k) && continue
v === nothing && continue
newvals[k] = v
end
return newvals
Expand Down
9 changes: 9 additions & 0 deletions test/downstream/modelingtoolkit_remake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,3 +397,12 @@ end
# old value retained
@test prob2.ps[Gamma] ≈ 3.0
end

@testset "`nothing` value for variable specified as `Symbol`" begin
@variables x(t) [guess = 1.0] y(t) [guess = 1.0]
@parameters p [guess = 1.0] q [guess = 1.0]
@mtkbuild sys = ODESystem(
[D(x) ~ p * x + q * y, y ~ 2x], t; parameter_dependencies = [q ~ 2p])
prob = ODEProblem(sys, [:x => 1.0], (0.0, 1.0), [p => 1.0])
@test_nowarn remake(prob; u0 = [:y => 1.0, :x => nothing])
end
Loading