Skip to content

Conversation

@pitx-perf
Copy link

@pitx-perf pitx-perf commented Feb 27, 2025

Tentative to fix: #945

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@pitx-perf pitx-perf changed the title Fix: make isclock robust to non TimeDomain argument Fix: make isclock robust to non TimeDomain argument https://github.com/SciML/SciMLBase.jl/issues/945 Feb 27, 2025
@pitx-perf pitx-perf changed the title Fix: make isclock robust to non TimeDomain argument https://github.com/SciML/SciMLBase.jl/issues/945 Fix: make isclock robust to non TimeDomain argument Feb 27, 2025
Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. This looks good if tests pass. It seems the issue is because Moshi uses the function Moshi.Data.isa_variant to check if a given object is the specified ADT variant, but the function is not robust to arguments that aren't a variant of the ADT.

@ChrisRackauckas ChrisRackauckas merged commit cc43377 into SciML:master Feb 28, 2025
28 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isclock is not robust to non TimeDomain argument

3 participants