Skip to content

Fix: make isclock robust to non TimeDomain argument #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix: make isclock robust to non TimeDomain argument #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae78a5c
Make isclock robust to non TimeDomain argument
Feb 27, 2025
1e511f8
same for issolverstepclock and iscontinuous
Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/clock.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,17 @@ discrete-time systems that assume a fixed sample time, such as PID controllers a
filters.
""" SolverStepClock

isclock(c) = @match c begin
isclock(c) = isa(c, TimeDomain) && @match c begin
PeriodicClock() => true
_ => false
end

issolverstepclock(c) = @match c begin
issolverstepclock(c) = isa(c, TimeDomain) && @match c begin
SolverStepClock() => true
_ => false
end

iscontinuous(c) = @match c begin
iscontinuous(c) = isa(c, TimeDomain) && @match c begin
ContinuousClock() => true
_ => false
end
Expand Down
3 changes: 3 additions & 0 deletions test/clock.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ using MLStyle: @match
@test isclock(PeriodicClock(; dt = 1.0))
@test !isclock(Continuous())
@test !isclock(SolverStepClock())
@test !isclock(nothing)

@test !issolverstepclock(PeriodicClock(; dt = 1.0))
@test !issolverstepclock(Continuous())
@test issolverstepclock(SolverStepClock())
@test !issolverstepclock(nothing)

@test !iscontinuous(PeriodicClock(; dt = 1.0))
@test iscontinuous(Continuous())
@test !iscontinuous(SolverStepClock())
@test !iscontinuous(nothing)

@test is_discrete_time_domain(PeriodicClock(; dt = 1.0))
@test !is_discrete_time_domain(Continuous())
Expand Down
Loading