Skip to content

Commit 107eab3

Browse files
All Errors Fixed
1 parent 47748b8 commit 107eab3

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

benchmarks/ParameterEstimation/FitzHughNagumoParameterEstimation.jmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ Vern9 solver with reltol=1e-9 and abstol=1e-9 is used and the dataset is increas
192192

193193

194194
```julia
195-
obj = build_loss_objective(prob,Vern9(),L2Loss(t,data),Optimization.AutoForwardDiff(),tstops=t,reltol=1e-9,abstol=1e-9)
195+
obj = build_loss_objective(prob,Vern9(),L2Loss(time_points,data),Optimization.AutoForwardDiff(),tstops=time_points,reltol=1e-9,abstol=1e-9)
196196
optprob = OptimizationProblem(obj, glo_init, lb = first.(glo_bounds), ub = last.(glo_bounds))
197197
@btime res1 = solve(optprob, BBO_adaptive_de_rand_1_bin(), maxiters = 4e3)
198198
```

benchmarks/ParameterEstimation/LorenzParameterEstimation.jmd

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ author: finmod, Chris Rackauckas, Vaibhav Dixit
55

66
# Estimate the parameters of the Lorenz system from the dataset
77

8-
9-
108
Note: If data is generated with a fixed time step method and then is tested against with the same time step, there is a biased introduced since it's no longer about hitting the true solution, rather it's just about retrieving the same values that the ODE was first generated by! Thus this version uses adaptive timestepping for all portions so that way tests are against the true solution.
119

1210
```julia
@@ -219,7 +217,7 @@ Vern9 solver with reltol=1e-9 and abstol=1e-9 has been established to be accurat
219217

220218
```julia
221219
# BB with Vern9 converges very slowly. The final values are within the NarrowBounds.
222-
obj = build_loss_objective(prob,Vern9(),L2Loss(t,data),tstops=t,reltol=1e-9,abstol=1e-9)
220+
obj = build_loss_objective(prob,Vern9(),L2Loss(time_points,data),tstops=time_points,reltol=1e-9,abstol=1e-9)
223221
optprob = OptimizationProblem(obj, GloIniPar, lb = first.(LooserBounds), ub = last.(LooserBounds))
224222
@btime res1 = solve(optprob, BBO_adaptive_de_rand_1_bin(); maxiters = 4e3) # Default adaptive_de_rand_1_bin_radiuslimited 33 sec [10.2183, 24.6711, 2.28969]
225223
#@btime res1 = bboptimize(obj;SearchRange = LooserBounds, Method = :adaptive_de_rand_1_bin, MaxSteps = 4e3) # Method 32 sec [13.2222, 25.8589, 2.56176]

0 commit comments

Comments
 (0)