Skip to content

Commit 53a1011

Browse files
ChrisRackauckasclaude
ChrisRackauckas
and
claude
committed
Fix: Remove static array versions of IRKGL16 methods
IRKGL16 methods from IRKGaussLegendre.jl are in-place only and cannot be used with static arrays (prob_choice => 2). This commit removes all static array versions and updates solution names accordingly. Changes: • Remove all Dict(:alg=>IRKGL16(...), :prob_choice => 2) entries • Update solution names to remove references to static versions • Keep only in-place compatible IRKGL16(simd=false/true) methods • Reformat files for consistent styling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 998178e commit 53a1011

File tree

3 files changed

+7
-31
lines changed

3 files changed

+7
-31
lines changed

‎benchmarks/NonStiffODE/LotkaVolterra_wpd.jmd‎

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ setups = [Dict(:alg=>DP5())
4646
Dict(:alg=>IRKGL16(simd = true))
4747
Dict(:alg=>Tsit5(), :prob_choice => 2)
4848
Dict(:alg=>Vern6(), :prob_choice => 2)
49-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
50-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
5149
Dict(:alg=>MER5v2(), :prob_choice => 2)
5250
Dict(:alg=>MER6v2(), :prob_choice => 2)
5351
Dict(:alg=>RK6v4(), :prob_choice => 2)]
@@ -70,9 +68,7 @@ setups = [Dict(:alg=>DP5())
7068
Dict(:alg=>IRKGL16(simd = false))
7169
Dict(:alg=>IRKGL16(simd = true))
7270
Dict(:alg=>Tsit5(), :prob_choice => 2)
73-
Dict(:alg=>Vern6(), :prob_choice => 2)
74-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
75-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)]
71+
Dict(:alg=>Vern6(), :prob_choice => 2)]
7672
wp = WorkPrecisionSet(
7773
probs, abstols, reltols, setups; appxsol = test_sol, maxiters = 10000,
7874
error_estimate = :L2, dense_errors = true, numruns = 100)
@@ -96,9 +92,7 @@ setups = [Dict(:alg=>DP8())
9692
Dict(:alg=>Vern6(), :prob_choice => 2)
9793
Dict(:alg=>Vern7(), :prob_choice => 2)
9894
Dict(:alg=>Vern8(), :prob_choice => 2)
99-
Dict(:alg=>Vern9(), :prob_choice => 2)
100-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
101-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)]
95+
Dict(:alg=>Vern9(), :prob_choice => 2)]
10296
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol,
10397
save_everystep = false, maxiters = 1000, numruns = 100)
10498
plot(wp)
@@ -117,8 +111,6 @@ setups = [Dict(:alg=>odex())
117111
Dict(:alg=>Vern7(), :prob_choice => 2)
118112
Dict(:alg=>Vern8(), :prob_choice => 2)
119113
Dict(:alg=>Vern9(), :prob_choice => 2)
120-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
121-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
122114
Dict(:alg=>CVODE_Adams())
123115
Dict(:alg=>lsoda())
124116
Dict(:alg=>ARKODE(Sundials.Explicit(), order = 6))]
@@ -141,9 +133,7 @@ setups = [Dict(:alg=>DP8())
141133
Dict(:alg=>Vern6(), :prob_choice => 2)
142134
Dict(:alg=>Vern7(), :prob_choice => 2)
143135
Dict(:alg=>Vern8(), :prob_choice => 2)
144-
Dict(:alg=>Vern9(), :prob_choice => 2)
145-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
146-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)]
136+
Dict(:alg=>Vern9(), :prob_choice => 2)]
147137
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol, dense = true,
148138
maxiters = 1000, error_estimate = :L2, numruns = 100)
149139
plot(wp)
@@ -166,15 +156,13 @@ setups = [Dict(:alg=>Tsit5())
166156
Dict(:alg=>IRKGL16(simd = true))
167157
Dict(:alg=>Vern9(), :prob_choice => 2)
168158
Dict(:alg=>VCABM(), :prob_choice => 2)
169-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
170-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
171159
Dict(:alg=>AitkenNeville(min_order = 1, max_order = 9, init_order = 4, threading = true))
172160
Dict(:alg=>ExtrapolationMidpointDeuflhard(
173161
min_order = 1, max_order = 9, init_order = 4, threading = true))
174162
Dict(:alg=>ExtrapolationMidpointHairerWanner(
175163
min_order = 2, max_order = 11, init_order = 4, threading = true))]
176164
solnames = ["Tsit5", "Vern9", "VCABM", "IRKGL16", "IRKGL16 SIMD",
177-
"Vern9 Static", "VCABM Static", "IRKGL16 Static", "IRKGL16 SIMD Static",
165+
"Vern9 Static", "VCABM Static",
178166
"AitkenNeville", "Midpoint Deuflhard", "Midpoint Hairer Wanner"]
179167
wp = WorkPrecisionSet(
180168
probs, abstols, reltols, setups; appxsol = test_sol, names = solnames,

‎benchmarks/NonStiffODE/RigidBody_wpd.jmd‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ setups = [Dict(:alg=>DP5())
4343
Dict(:alg=>IRKGL16(simd = true))
4444
Dict(:alg=>Tsit5(), :prob_choice => 2)
4545
Dict(:alg=>Vern6(), :prob_choice => 2)
46-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
47-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
4846
Dict(:alg=>MER5v2(), :prob_choice => 2)
4947
Dict(:alg=>MER6v2(), :prob_choice => 2)
5048
Dict(:alg=>RK6v4(), :prob_choice => 2)]
@@ -70,9 +68,7 @@ setups = [Dict(:alg=>DP8())
7068
Dict(:alg=>Vern6(), :prob_choice => 2)
7169
Dict(:alg=>Vern7(), :prob_choice => 2)
7270
Dict(:alg=>Vern8(), :prob_choice => 2)
73-
Dict(:alg=>Vern9(), :prob_choice => 2)
74-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
75-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)]
71+
Dict(:alg=>Vern9(), :prob_choice => 2)]
7672
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol,
7773
save_everystep = false, numruns = 100, maxiters = 1000)
7874
plot(wp)

‎benchmarks/NonStiffODE/ThreeBody_wpd.jmd‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ setups = [Dict(:alg=>DP5())
8383
Dict(:alg=>Tsit5())
8484
Dict(:alg=>IRKGL16(simd = true))
8585
Dict(:alg=>Tsit5(), :prob_choice => 2)
86-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
8786
Dict(:alg=>dopri5())];
8887
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol,
8988
save_everystep = false, numruns = 100)
@@ -114,7 +113,6 @@ setups = [Dict(:alg=>DP5())
114113
Dict(:alg=>Tsit5())
115114
Dict(:alg=>IRKGL16(simd = true))
116115
Dict(:alg=>Tsit5(), :prob_choice => 2)
117-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
118116
Dict(:alg=>dopri5())];
119117
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol, numruns = 100)
120118
plot(wp)
@@ -138,9 +136,7 @@ setups = [Dict(:alg=>DP5())
138136
Dict(:alg=>Vern6(), :prob_choice => 2)
139137
Dict(:alg=>Vern7(), :prob_choice => 2)
140138
Dict(:alg=>Vern8(), :prob_choice => 2)
141-
Dict(:alg=>Vern9(), :prob_choice => 2)
142-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
143-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)];
139+
Dict(:alg=>Vern9(), :prob_choice => 2)];
144140
wp = WorkPrecisionSet(probs, abstols, reltols, setups; appxsol = test_sol,
145141
save_everystep = false, numruns = 100)
146142
plot(wp)
@@ -177,8 +173,6 @@ setups = [Dict(:alg=>DP5())
177173
Dict(:alg=>IRKGL16(simd = false))
178174
Dict(:alg=>IRKGL16(simd = true))
179175
Dict(:alg=>Vern8(), :prob_choice => 2)
180-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
181-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
182176
Dict(:alg=>ddeabm())
183177
Dict(:alg=>odex())
184178
Dict(:alg=>ARKODE(Sundials.Explicit(), order = 6))];
@@ -202,15 +196,13 @@ setups = [Dict(:alg=>Tsit5())
202196
Dict(:alg=>IRKGL16(simd = false))
203197
Dict(:alg=>IRKGL16(simd = true))
204198
Dict(:alg=>Vern9(), :prob_choice => 2)
205-
Dict(:alg=>IRKGL16(simd = false), :prob_choice => 2)
206-
Dict(:alg=>IRKGL16(simd = true), :prob_choice => 2)
207199
Dict(:alg=>AitkenNeville(min_order = 1, max_order = 9, init_order = 4, threading = true))
208200
Dict(:alg=>ExtrapolationMidpointDeuflhard(
209201
min_order = 1, max_order = 9, init_order = 4, threading = true))
210202
Dict(:alg=>ExtrapolationMidpointHairerWanner(
211203
min_order = 2, max_order = 11, init_order = 4, threading = true))]
212204
solnames = ["Tsit5", "Vern9", "IRKGL16", "IRKGL16 SIMD",
213-
"Vern9 Static", "IRKGL16 Static", "IRKGL16 SIMD Static",
205+
"Vern9 Static",
214206
"AitkenNeville", "Midpoint Deuflhard", "Midpoint Hairer Wanner"]
215207
wp = WorkPrecisionSet(
216208
probs, abstols, reltols, setups; appxsol = test_sol, names = solnames,

0 commit comments

Comments
 (0)