Apply suggestions from code review

Author: ChrisRackauckas

benchmarks/OptimizationCUTEst/CUTEst_bounded.jmd

@@ -69,7 +69,7 @@ function run_benchmarks(problems, optimizers; chunk_size=1)
                     finalize(nlp_prob)
                     continue
                 end
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
                 for (optimizer_name, optimizer) in optimizers
                     try
                         sol = solve(prob, optimizer; maxiters = 1000, maxtime = 30.0)

benchmarks/OptimizationCUTEst/CUTEst_quadratic.jmd

@@ -67,7 +67,7 @@ function run_benchmarks(problems, optimizers; chunk_size=1)
                     finalize(nlp_prob)
                     continue
                 end
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
                 for (optimizer_name, optimizer) in optimizers
                     try
                         sol = solve(prob, optimizer; maxiters = 1000, maxtime = 30.0)
@@ -165,7 +165,7 @@ function run_quadratic_benchmarks(problems, optimizers; chunk_size=3)
                     finalize(nlp_prob)
                     continue
                 end
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
                 for (optimizer_name, optimizer) in optimizers
                     try
                         sol = solve(prob, optimizer; maxiters = 1000, maxtime = 30.0)

benchmarks/OptimizationCUTEst/CUTEst_safe_solvers.jmd

@@ -81,7 +81,7 @@ function run_benchmarks(problems, optimizers; chunk_size=1)
                     continue
                 end
 
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
 
                 for (optimizer_name, optimizer) in optimizers
                     @printf("  Testing %-20s... ", optimizer_name)

benchmarks/OptimizationCUTEst/CUTEst_unbounded.jmd

@@ -78,7 +78,7 @@ function run_benchmarks(problems, optimizers; chunk_size=3)
                     finalize(nlp_prob)
                     continue
                 end
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
                 for (optimizer_name, optimizer) in optimizers
                     try
                         sol = solve(prob, optimizer; maxiters = 1000, maxtime = 30.0)

benchmarks/OptimizationCUTEst/CUTEst_unconstrained.jmd

@@ -97,7 +97,7 @@ function run_benchmarks(problems, optimizers; chunk_size=1)
                     finalize(nlp_prob)
                     continue
                 end
-                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoForwardDiff())
+                prob = OptimizationNLPModels.OptimizationProblem(nlp_prob, Optimization.AutoFiniteDiff())
                 for (optimizer_name, optimizer) in optimizers
                     try
                         sol = solve(prob, optimizer; maxiters = 1000, maxtime = 30.0)