Skip to content

Commit f96b9bd

Browse files
Merge pull request #534 from SciML/bcrtypo
Fix typo in BCR
2 parents d208fdd + 12b8040 commit f96b9bd

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

benchmarks/Bio/BCR.jmd

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,16 @@ tf = 100000.0
2626

2727
# generate ModelingToolkit ODEs
2828
@timeit to "Parse Network" prnbng = loadrxnetwork(BNGNetwork(), joinpath(datadir, "bcr.net"))
29-
show(to)
29+
show(to)
3030
rn = prnbng.rn
3131
obs = [eq.lhs for eq in observed(rn)]
3232

3333
@timeit to "Create ODESys" osys = convert(ODESystem, rn)
34-
show(to)
34+
show(to)
3535

3636
tspan = (0.,tf)
3737
@timeit to "ODEProb No Jac" oprob = ODEProblem(osys, Float64[], tspan, Float64[])
38-
show(to)
38+
show(to)
3939
oprob_sparse = ODEProblem(osys, Float64[], tspan, Float64[]; sparse=true);
4040
```
4141

@@ -120,7 +120,7 @@ W = I - 1.0*jaccache
120120
prectmp = ilu(W, τ = 50.0)
121121
preccache = Ref(prectmp)
122122

123-
τ1 = 1e2
123+
const τ1 = 1e2
124124
function psetupilu(p, t, u, du, jok, jcurPtr, gamma)
125125
if jok
126126
sparsejacprob.f.jac(jaccache,u,p,t)
@@ -139,7 +139,7 @@ function precilu(z,r,p,t,y,fy,gamma,delta,lr)
139139
ldiv!(z,preccache[],r)
140140
end
141141

142-
τ2 = 1e10
142+
const τ2 = 1e2
143143
function incompletelu(W,du,u,p,t,newW,Plprev,Prprev,solverdata)
144144
if newW === nothing || newW
145145
Pl = ilu(convert(AbstractMatrix,W), τ = τ2)
@@ -163,7 +163,7 @@ Before proceding to the results, we note the notable omissions. CVODE with KLU d
163163
thus it is omitted from the results:
164164

165165
```julia
166-
solve(sparsejacprob,CVODE_BDF(linear_solver=:KLU), abstol=1e-5, reltol=1e-5)
166+
solve(sparsejacprob,CVODE_BDF(linear_solver=:KLU), abstol=1e-8, reltol=1e-8);
167167
```
168168

169169
## Work-Precision Diagrams (CVODE and lsoda solvers)
@@ -242,10 +242,10 @@ plot(wp;label=names,xlimit=xlimit,ylimit=ylimit)
242242

243243
```julia
244244
setups = [
245-
Dict(:alg=>TRBDF2(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu_fceri,concrete_jac=true)),
246-
Dict(:alg=>QNDF(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu_fceri,concrete_jac=true)),
247-
Dict(:alg=>FBDF(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu_fceri,concrete_jac=true)),
248-
Dict(:alg=>KenCarp4(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu_fceri,concrete_jac=true))
245+
Dict(:alg=>TRBDF2(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu,concrete_jac=true)),
246+
Dict(:alg=>QNDF(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu,concrete_jac=true)),
247+
Dict(:alg=>FBDF(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu,concrete_jac=true)),
248+
Dict(:alg=>KenCarp4(linsolve=KrylovJL_GMRES(),autodiff=false,precs=incompletelu,concrete_jac=true))
249249
];
250250
```
251251

0 commit comments

Comments
 (0)