Skip to content

Conversation

@ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

This PR is mixing changes.

@ChrisRackauckas
Copy link
Member

Rebase so it runs the build

@ChrisRackauckas ChrisRackauckas merged commit 476fe38 into SciML:master Oct 21, 2024
2 checks passed
@ChrisRackauckas
Copy link
Member

Oh wait shit, you didn't bump the manifest. The manifest needs to be bumped or it's not updating the actual packages used!

@ParamThakkar123
Copy link
Contributor Author

Oh wait shit, you didn't bump the manifest. The manifest needs to be bumped or it's not updating the actual packages used!

Oh, Okay. I will bump the manifest and make another pull request. I think I did it but maybe that didn't happen.

@ParamThakkar123
Copy link
Contributor Author

Actually I was working on this one yesterday. But still some needed fix. I was working on it. Somehow all the checks passed but I noticed this yesterday that the manifest needs a bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants