added nand gate problem benchmark #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| M = zeros(14, 14) | ||
| capacitance_matrix!(M, y0, 0.0) | ||
| f = ODEFunction(nand_rhs!, mass_matrix=M) | ||
| prob = ODEProblem(f, y0, tspan) |
Member
There was a problem hiding this comment.
Needs a DAEProblem formulation as well to test IDA, and should have an MTK version. See the other DAE benchmarks.
Member
There was a problem hiding this comment.
Note that the 3 can all be generated from the same form so it shouldn't be too much more code, and the static array version isn't necessary here.
Member
|
Can you show the validation plots of the solution from the original benchmark specification vs the ones generated with this to eyeball that it's the same standard DAE? |
Member
|
The validation plots look correct. |
ChrisRackauckas
closed this pull request by merging all changes
into
SciML:master
in
15cdd7d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.