base zero, one

Author: vpuri3

src/SciMLOperators.jl

@@ -11,8 +11,8 @@ import Lazy: @forward
 import Setfield: @set!
 
 # overload
-import Base: +, -, *, /, \, ∘, ==
-import Base: conj, one, iszero, inv, adjoint, transpose, size, convert, Matrix
+import Base: +, -, *, /, \, ∘, ==, one, zero
+import Base: conj, iszero, inv, adjoint, transpose, size, convert, Matrix
 import LinearAlgebra: mul!, ldiv!, lmul!, rmul!, factorize, exp, Diagonal
 import SparseArrays: sparse
 

src/basic.jl

@@ -12,7 +12,6 @@ function Base.one(A::AbstractSciMLOperator)
     IdentityOperator{N}()
 end
 
-# TODO - sparse diagonal
 Base.convert(::Type{AbstractMatrix}, ::IdentityOperator{N}) where{N} = Diagonal(ones(Bool, N))
 
 # traits
@@ -187,6 +186,8 @@ function Base.adjoint(α::ScalarOperator) # TODO - test
     ScalarOperator(val; update_func=update_func)
 end
 Base.transpose(α::ScalarOperator) = α
+Base.one(::Type{AbstractSciMLOperator}) = ScalarOperator(true)
+Base.zero(::Type{AbstractSciMLOperator}) = ScalarOperator(false)
 
 getops(α::ScalarOperator) = (α.val,)
 islinear(L::ScalarOperator) = true