Merge pull request #149 from vpuri3/issq

check first two dimensions for `issquare`

Author: ChrisRackauckas

src/func.jl

@@ -171,7 +171,7 @@ function FunctionOperator(op,
                     )
 end
 
-function update_coefficients(L, u, p, t)
+function update_coefficients(L::FunctionOperator, u, p, t)
     op = update_coefficients(L.op, u, p, t)
     op_adjoint = update_coefficients(L.op_adjoint, u, p, t)
     op_inverse = update_coefficients(L.op_inverse, u, p, t)

src/interface.jl

@@ -186,17 +186,22 @@ has_adjoint(::Union{
                    }
            ) = true
 
-issquare(L) = isequal(size(L)...)
+issquare(L) = ndims(L) >= 2 && size(L, 1) == size(L, 2)
+issquare(::AbstractVector) = false
 issquare(::Union{
                  # LinearAlgebra
                  UniformScaling,
 
+                 # SciMLOperators
+                 AbstractSciMLScalarOperator,
+
                  # Base
                  Number,
                 }
         ) = true
 issquare(A...) = @. (&)(issquare(A)...)
 
+Base.ndims(L::AbstractSciMLOperator) = length(size(L))
 Base.isreal(L::AbstractSciMLOperator{T}) where{T} = T <: Real
 Base.Matrix(L::AbstractSciMLOperator) = Matrix(convert(AbstractMatrix, L))
 

src/scalar.jl

@@ -26,7 +26,6 @@ Base.adjoint(α::AbstractSciMLScalarOperator) = conj(α)
 Base.transpose(α::AbstractSciMLScalarOperator) = α
 
 has_mul!(::AbstractSciMLScalarOperator) = true
-issquare(::AbstractSciMLScalarOperator) = true
 islinear(::AbstractSciMLScalarOperator) = true
 has_adjoint(::AbstractSciMLScalarOperator) = true