Merge pull request #189 from vpuri3/sca

scalar op multiplcation fix when arguments are numbers

Author: xtalax

src/interface.jl

@@ -19,6 +19,12 @@ end
 (L::AbstractSciMLOperator)(du, u, p, t) = (update_coefficients!(L, u, p, t); mul!(du, L, u))
 (L::AbstractSciMLOperator)(du, u, p, t, α, β) = (update_coefficients!(L, u, p, t); mul!(du, L, u, α, β))
 
+function (L::AbstractSciMLOperator)(du::Number, u::Number, p, t, args...)
+    msg = """Nonallocating L(v, u, p, t) type methods are not available for
+    subtypes of `Number`."""
+    throw(ArgumentError(msg))
+end
+
 ###
 # caching interface
 ###

src/scalar.jl

@@ -3,6 +3,11 @@
 # AbstractSciMLScalarOperator interface
 ###
 
+function (L::AbstractSciMLScalarOperator)(u::Number, p, t)
+    L = update_coefficients(L, u, p, t)
+    convert(Number, L) * u
+end
+
 SCALINGNUMBERTYPES = (
                       :AbstractSciMLScalarOperator,
                       :Number,

test/scalar.jl

@@ -93,6 +93,20 @@ K = 12
     for op in L.ops
         @test !isa(op, ComposedScalarOperator)
     end
+
+end
+
+@testset "ScalarOperator scalar argument test" begin
+    a = rand()
+    u = rand()
+    v = rand()
+    p = nothing
+    t = 0.0
+
+    α = ScalarOperator(a)
+    @test α(u, p, t) ≈ u * a
+    @test_throws ArgumentError α(v, u, p, t)
+    @test_throws ArgumentError α(v, u, p, t, 1, 2)
 end
 
 @testset "ScalarOperator update test" begin