isempty-bang

Author: vpuri3

src/basic.jl

@@ -293,6 +293,7 @@ struct AddedOperator{T,
     ops::O
 
     function AddedOperator(ops)
+        @assert !isempty(ops)
         T = promote_type(eltype.(ops)...)
         new{T,typeof(ops)}(ops)
     end
@@ -414,6 +415,7 @@ struct ComposedOperator{T,O,C} <: AbstractSciMLOperator{T}
     isset::Bool
 
     function ComposedOperator(ops, cache, isset::Bool)
+        @assert !isempty(ops)
         for i in reverse(2:length(ops))
             opcurr = ops[i]
             opnext = ops[i-1]

src/scalar.jl

@@ -115,6 +115,7 @@ struct AddedScalarOperator{T,O} <: AbstractSciMLScalarOperator{T}
     ops::O
 
     function AddedScalarOperator(ops::NTuple{N,AbstractSciMLScalarOperator}) where{N}
+        @assert !isempty(ops)
         T = promote_type(eltype.(ops)...)
         new{T,typeof(ops)}(ops)
     end
@@ -140,18 +141,18 @@ for op in (
     end
 end
 
-#function Base.convert(::Type{Number}, α::AddedScalarOperator{T}) where{T}
-#    sum(op -> convert(Number, op), α.ops; init=zero(T))
-#end
-
 function Base.convert(::Type{Number}, α::AddedScalarOperator{T}) where{T}
-    val = zero(T)
-    for op in α.ops
-        val += convert(Number, op)
-    end
-    val
+    sum(op -> convert(Number, op), α.ops)
 end
 
+#function Base.convert(::Type{Number}, α::AddedScalarOperator{T}) where{T}
+#    val = zero(T)
+#    for op in α.ops
+#        val += convert(Number, op)
+#    end
+#    val
+#end
+
 Base.conj(L::AddedScalarOperator) = AddedScalarOperator(conj.(L.ops))
 
 getops(α::AddedScalarOperator) = α.ops
@@ -165,6 +166,7 @@ struct ComposedScalarOperator{T,O} <: AbstractSciMLScalarOperator{T}
     ops::O
 
     function ComposedScalarOperator(ops::NTuple{N,AbstractSciMLScalarOperator}) where{N}
+        @assert !isempty(ops)
         T = promote_type(eltype.(ops)...)
         new{T,typeof(ops)}(ops)
     end