Put appropriate type of alias specifier in to solve in DynamicSS #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| haskey(odesolve_kwargs, :callback) && | ||
| (callback = CallbackSet(callback, odesolve_kwargs[:callback])) | ||
| kwargs = pairs(merge((; kwargs...), haskey(kwargs, :verbose) ? (verbose=true,) : (;))) | ||
| kwargs = pairs(merge((; kwargs...), |
Member
Author
There was a problem hiding this comment.
merge takes the value of the right most named tuple, so if kwargs has an alias_u0 key, it will use ODEAliasSpecifier(; u0=kwargs[:alias_u0]) for alias.
Should we be passing kwargs to solve here anyways? The kwargs that should go in to the ODE solve should be in odesolve_kwargs?
jClugstor
force-pushed
the
fix_aliases
branch
from
8c4f68d to
aea13cb
Compare
Member
Author
|
Oh I see this was handled by #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
We were putting a NonlinearAliasSpecifier in to an ODE solve