-
-
Notifications
You must be signed in to change notification settings - Fork 22
Fix alias u0 deprecation #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alias u0 deprecation #98
Conversation
|
It shouldn't be sending it anymore 😅 |
|
@jClugstor did you never handle NonlinearSolve? |
|
It should be handled? Not sure why this is still giving the dep warning. Only thing I can see is the |
|
The issue is in NonlinearSolve's |
|
I've updated the PR to use the standard NonlinearAliasSpecifier interface instead of alias_u0. Changes Made:
Code Changes:# Before (line 19):
alias_u0 = false, kwargs...)
# After:
alias = SciMLBase.NonlinearAliasSpecifier(), kwargs...)
# Before (lines 56-58):
odesol = solve(odeprob, alg.alg, args...; abstol, reltol, kwargs...,
odesolve_kwargs..., callback, save_end = true,
alias = SciMLBase.ODEAliasSpecifier(; alias_u0))
# After:
odesol = solve(odeprob, alg.alg, args...; abstol, reltol, kwargs...,
odesolve_kwargs..., callback, save_end = true,
alias = SciMLBase.ODEAliasSpecifier(; alias_p = alias.alias_p,
alias_f = alias.alias_f, alias_u0 = alias.alias_u0))Testing:All tests pass successfully with these changes:
The warnings about Patch:Here's the git diff for easy application: ```diff
This aligns with the standard alias interface used throughout NonlinearSolve.jl and properly converts the NonlinearAliasSpecifier to ODEAliasSpecifier when calling the ODE solver. |
|
Yeah we'll need to thread the alias specifier through to all of the The |
|
I applied the fix from @ChrisRackauckas-Claude , but this will need SciML/NonlinearSolve.jl#720 before it can merge |
|
Bump lower bounds? |
|
CI is hitting #99 |
|
Rebase |
NonlinearSolve is passing this Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Christopher Rackauckas <[email protected]> Co-authored-by: Claude <[email protected]>
7e9e795 to
79523f9
Compare
NonlinearSolve is sending
alias_u0, is it ok to convert that or should we change NonlinearSolve to send theNonlinearAliasSpecifierand convert it to aODEAliasSpecifier?This would be one way to fix #97