better errors on invalid alg interpretations

Author: ChrisRackauckas

src/alg_utils.jl

@@ -125,7 +125,7 @@ alg_interpretation(alg::RKMil{interpretation}) where {interpretation} = interpre
 alg_interpretation(alg::SROCK1{interpretation}) where {interpretation} = interpretation
 alg_interpretation(alg::RKMilCommute{interpretation}) where {interpretation} = interpretation
 alg_interpretation(alg::RKMilGeneral) = alg.interpretation
-alg_interpretation(alg::ImplicitRKMil{CS,AD,F,S,N,T2,Controller,interpretation}) where {CS,AD,F,S,N,T2,Controller,interpretation} = interpretation
+alg_interpretation(alg::ImplicitRKMil{CS,AD,F,FDT,ST,N,T2,Controller,interpretation}) where {CS,AD,F,FDT,ST,N,T2,Controller,interpretation} = interpretation
 
 alg_interpretation(alg::RS1) = :Stratonovich
 alg_interpretation(alg::RS2) = :Stratonovich
@@ -263,8 +263,8 @@ OrdinaryDiffEq.get_chunksize(alg::StochasticDiffEqJumpNewtonDiffusionAdaptiveAlg
 end
 
 @static if isdefined(OrdinaryDiffEq,:alg_difftype)
-    OrdinaryDiffEq.alg_difftype(alg::Union{StochasticDiffEqNewtonAdaptiveAlgorithm{CS,AD,FDT,Controller},
-                                StochasticDiffEqNewtonAlgorithm{CS,AD,FDT,Controller}}) where {CS,AD,FDT,Controller} = FDT
+    OrdinaryDiffEq.alg_difftype(alg::Union{StochasticDiffEqNewtonAdaptiveAlgorithm{CS,AD,FDT,ST,Controller},
+                                StochasticDiffEqNewtonAlgorithm{CS,AD,FDT,ST,Controller}}) where {CS,AD,FDT,ST,Controller} = FDT
 end
 
 alg_mass_matrix_compatible(alg::StochasticDiffEqAlgorithm) = false

src/perform_step/SROCK_perform_step.jl

@@ -73,6 +73,8 @@
         gₘ₋₂ = integrator.g(uᵢ₋₁,p,tᵢ₋₁)
         u += gₘ₋₂*W.dW
       end
+    else
+      error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
     end
 
     if i < mdeg
@@ -163,6 +165,8 @@ end
         mul!(uᵢ₋₁,gₘ₋₂,W.dW)
         @.. u += uᵢ₋₁
       end
+    else
+      error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
     end
 
     if i < mdeg

src/perform_step/low_order.jl

@@ -179,6 +179,8 @@ end
     utilde = uprev + L*integrator.sqdt
     ggprime = (integrator.g(utilde,p,t).-L)./(integrator.sqdt)
     mil_correction = ggprime.*(W.dW.^2)./2
+  else
+    error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
   end
   u = K+L.*W.dW+mil_correction
   if integrator.opts.adaptive
@@ -207,6 +209,8 @@ end
     @.. tmp = (du2-L)/(2integrator.sqdt)*(W.dW^2 - dt)
   elseif alg_interpretation(integrator.alg) == :Stratonovich
     @.. tmp = (du2-L)/(2integrator.sqdt)*(W.dW^2)
+  else
+    error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
   end
   @.. u = K+L*W.dW + tmp
   if integrator.opts.adaptive
@@ -232,6 +236,8 @@ end
     @.. tmp = uprev + integrator.sqdt * L
     integrator.g(du2,tmp,p,t)
     @.. tmp = (du2-L)/(2integrator.sqdt)*(W.dW.^2)
+  else
+    error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
   end
   @.. u = K+L*W.dW + tmp
   if integrator.opts.adaptive

src/perform_step/sdirk.jl

@@ -37,6 +37,8 @@
       ggprime = (integrator.g(utilde,p,t).-L)./(integrator.sqdt)
       mil_correction = ggprime.*(integrator.W.dW.^2)./2
       gtmp += mil_correction
+    else
+      error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
     end
   end
 
@@ -162,6 +164,8 @@ end
       integrator.g(gtmp3,z,p,t)
       @.. gtmp3 = (gtmp3-gtmp)/(integrator.sqdt) # ggprime approximation
       @.. gtmp2 += gtmp3*(dW.^2)/2
+    else
+      error("Alg interpretation invalid. Use either :Ito or :Stratonovich")
     end
   end