Skip to content

Conversation

@AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal marked this pull request as draft August 25, 2025 12:30
@AayushSabharwal AayushSabharwal changed the title feat: integrate callback saving into integrator init and finalize [WIP] feat: integrate callback saving into integrator init and finalize Aug 25, 2025
@AayushSabharwal AayushSabharwal marked this pull request as ready for review September 3, 2025 06:26
@AayushSabharwal AayushSabharwal changed the title [WIP] feat: integrate callback saving into integrator init and finalize feat: integrate callback saving into integrator init and finalize Sep 3, 2025
@ChrisRackauckas ChrisRackauckas merged commit 0f7073f into SciML:master Sep 3, 2025
44 of 60 checks passed
ChrisRackauckas-Claude pushed a commit to ChrisRackauckas-Claude/StochasticDiffEq.jl that referenced this pull request Sep 3, 2025
…mpProcesses

This fixes the test failures in Interface1 and Interface2 by properly implementing
TauLeaping algorithm support for DiscreteProblem when used with JumpProcesses.

The issue was that TauLeaping algorithms were not properly integrated with
DiscreteProblem, causing multiple dispatch failures. The fixes include:

1. **Method dispatch**: Extended __init signature to handle DiscreteProblem with
   StochasticDiffEqJumpAdaptiveAlgorithm

2. **Algorithm compatibility**: Added alg_compatible method for DiscreteProblem
   with TauLeaping algorithms

3. **Assertion fixes**: Updated assertions to accept both JumpProblem and
   DiscreteProblem

4. **Cache initialization**: Handle case where jump_rate_prototype is Nothing
   for discrete problems

5. **Initial timestep**: Skip noise function access for DiscreteProblem (no 'g' field)

6. **Noise handling**: Handle cases where jump process P is Nothing in perform_step!

7. **Adaptive stepping**: Add guards for adaptive stepping when P is Nothing

These changes restore the callback saving functionality from PR SciML#629 while
properly fixing the underlying TauLeaping integration issues that were
exposed by dependency updates.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@AayushSabharwal AayushSabharwal deleted the as/fix-disc-save branch September 3, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants