Merge pull request #449 from SciML/rff_bye_bye

Removing RFF functionality and using the dedicated package

Author: pogudingleb

Project.toml

@@ -18,6 +18,7 @@ ParamPunPam = "3e851597-e36f-45a9-af0a-b7781937992f"
 PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
 Primes = "27ebfcd6-29c5-5fa9-bf4b-fb8fc14df3ae"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
+RationalFunctionFields = "73480bc8-48a2-41cc-880f-208b490ccf65"
 TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
 
 [weakdeps]
@@ -40,16 +41,17 @@ IterTools = "1"
 LinearAlgebra = "1.10, 1.11"
 Logging = "1.10, 1.11"
 MacroTools = "0.5"
-ModelingToolkit = "10"
+ModelingToolkit = "10.22"
 Nemo = "0.46, 0.47, 0.48, 0.49, 0.50, 0.51, 0.52"
 ParamPunPam = "0.5"
 Pkg = "1.10, 1.11"
 PrecompileTools = "1.2"
 Primes = "0.5"
 Random = "1.10, 1.11"
+RationalFunctionFields = "0.2.1"
 SpecialFunctions = "2"
-SymbolicUtils = "3.27"
-Symbolics = "6.40"
+SymbolicUtils = "3.32"
+Symbolics = "6.55"
 Test = "1.10, 1.11"
 TestSetExtensions = "2"
 TimerOutputs = "0.5.10"

docs/pages.jl

@@ -10,7 +10,6 @@ pages = [
     "Basics" => Any["input/input.md", "identifiability/identifiability.md"],
     "Library" => Any[
         "Local Identifiability Tools" => "utils/local_identifiability.md",
-        "Global Identifiability Tools" => "utils/global_identifiability.md",
         "Elimination" => "utils/elimination.md",
         "ODE Tools" => "utils/ode.md",
         "Power Series Tools" => "utils/power_series_utils.md",

docs/src/utils/global_identifiability.md

@@ -211,30 +211,6 @@ function power_series_solution(
 end
 #------------------------------------------------------------------------------
 
-"""
-    _reduce_mod_p(f, p)
-
-Reduces a polynomial/rational function over Q modulo p
-"""
-function _reduce_mod_p(poly::QQMPolyRingElem, p::Int)
-    den = denominator(poly)
-    num = change_base_ring(Nemo.ZZ, den * poly)
-    if Nemo.Native.GF(p)(den) == 0
-        throw(Base.ArgumentError("Prime $p divides the denominator of $poly"))
-    end
-    return change_base_ring(Nemo.Native.GF(p), num) * (1 // Nemo.Native.GF(p)(den))
-end
-
-function _reduce_mod_p(rat::Generic.FracFieldElem{QQMPolyRingElem}, p::Int)
-    num, den = map(poly -> _reduce_mod_p(poly, p), [numerator(rat), denominator(rat)])
-    if den == 0
-        throw(Base.ArgumentError("Prime $p divides the denominator of $rat"))
-    end
-    return num // den
-end
-
-#--------------------------------------
-
 """
     reduce_ode_mod_p(ode, p)