Merge pull request #131 from SebastianM-C/smc/perf

Remove allocations in `setp`

Author: AayushSabharwal

Project.toml

@@ -17,6 +17,7 @@ SymbolicIndexingInterfacePrettyTablesExt = "PrettyTables"
 
 [compat]
 Accessors = "0.1.36"
+AllocCheck = "0.2"
 Aqua = "0.8"
 ArrayInterface = "7.9"
 Pkg = "1"
@@ -30,6 +31,7 @@ Zygote = "0.6.67"
 julia = "1.10"
 
 [extras]
+AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
@@ -38,4 +40,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [targets]
-test = ["Aqua", "Pkg", "Test", "SafeTestsets", "StaticArrays", "Zygote"]
+test = ["AllocCheck", "Aqua", "Pkg", "Test", "SafeTestsets", "StaticArrays", "Zygote"]

src/parameter_indexing.jl

@@ -713,7 +713,9 @@ struct MultipleSetters{S} <: AbstractSetIndexer
 end
 
 function (ms::MultipleSetters)(prob, val)
-    map((s!, v) -> s!(prob, v), ms.setters, val)
+    for (s!, v) in zip(ms.setters, val)
+        s!(prob, v)
+    end
 end
 
 for (t1, t2) in [

test/parameter_indexing_test.jl

@@ -5,6 +5,7 @@ using SymbolicIndexingInterface: IndexerOnlyTimeseries, IndexerNotTimeseries, In
                                  ParameterTimeseriesValueIndexMismatchError,
                                  MixedParameterTimeseriesIndexError
 using Test
+using AllocCheck
 
 arr = [1.0, 2.0, 3.0]
 @test parameter_values(arr) == arr
@@ -101,6 +102,12 @@ for sys in [
             else
                 set!(p, newval)
             end
+            if isconcretetype(eltype(newval))
+                # test only with concrete eltypes, otherwise we have
+                # dynamic dispatch due to the vals
+                @check_allocs test_setp(set!, p, newval) = set!(p, newval)
+                test_setp(set!, p, newval)
+            end
             @test get(p) == newval
             set!(p, oldval)
             @test get(p) == oldval