Merge pull request #120 from SciML/as/remake-buffer-bug

fix: fix stack overflow on `remake_buffer` of `Dict`

Author: AayushSabharwal

src/remake.jl

@@ -55,6 +55,12 @@ function remake_buffer(sys, oldbuffer::AbstractArray, idxs, vals)
     return newbuffer
 end
 
+# We don't support `Dict`s as value providers. If we get a `Dict`,
+# assume it is non-symbolic.
+function remake_buffer(sys, oldbuffer::Dict, idxs, vals)
+    return Dict(idxs .=> vals)
+end
+
 remake_buffer(sys, ::Nothing, idxs, vals) = nothing
 
 function remake_buffer(sys, oldbuffer, idxs, vals)

test/remake_test.jl

@@ -73,3 +73,12 @@ for (buf, newbuf, idxs, vals) in [
 end
 
 @test isnothing(remake_buffer(sys, nothing, [], []))
+
+@testset "`remake_buffer` with `Dict`" begin
+    sys = nothing
+    buf = Dict("a" => 1, "b" => 2)
+    buf2 = remake_buffer(sys, buf, collect(keys(buf)), collect(values(buf)))
+    @test isequal(buf, buf2)
+    buf2 = remake_buffer(sys, buf, buf)
+    @test isequal(buf, buf2)
+end