Merge pull request #71 from shahriariravanian/main

accept updated to allow for integration constants

Author: shahriariravanian

Project.toml

@@ -1,7 +1,7 @@
 name = "SymbolicNumericIntegration"
 uuid = "78aadeae-fbc0-11eb-17b6-c7ec0477ba9e"
 authors = ["Shahriar Iravanian <[email protected]>"]
-version = "1.3.0"
+version = "1.3.1"
 
 [deps]
 DataDrivenDiffEq = "2445eb08-9709-466a-b3fc-47e12bd697a2"

src/symbolic.jl

@@ -262,8 +262,18 @@ end
 # returns true if sol solves the integration problem represented by prob
 function accept(prob, sol)
     if sol != nothing
-        ε = accept_solution(prob.eq, prob.x, sol; prob.plan)
-        return ε < prob.plan.abstol
+        ε1 = accept_solution(prob.eq, prob.x, sol; prob.plan)
+
+        if ε1 < prob.plan.abstol
+            return true
+        end
+
+        ε2 = accept_solution(prob.eq, prob.x, sol; prob.plan)
+
+        # accept if integrals differ by a constant
+        if abs(ε1 - ε2) < prob.plan.abstol
+            return true
+        end
     end
     return false
 end

test/runtests.jl

@@ -214,6 +214,7 @@ sym_integrals = [
     # Basic Forms
     a * x^2,
     a * x + b * x^2 - c * x^3,
+    (3(x^2) + 3(a^2) - 4) / (4 * a * b),
     a / x,
     1 / (a * x + 5),
     1 / (x + a),