forked from FedeOmoto/bignum
-
Notifications
You must be signed in to change notification settings - Fork 2
design discussion #1
Copy link
Copy link
Open
Description
(migrated from FedeOmoto#4)
- reference type inputs shouldn't be returned
eg: in
proc set*(z, x: Int): Int =
## Sets `z` to `x` and returns `z`.
result = z
mpz_set(result[], x[])it's misleading and un-necessary to return z given that z gets modified; nim code doesn't usually do that, and for good reasons.
-
inc+decshould have a 1 argument overload (eg would allow generic algorithms where inc/dec work with 1 arg) -
module naming:
RatandIntare not great names, see also this thread https://forum.nim-lang.org/t/1296 -
the fork should host its own version of the docs instead of pointing to the source repo https://github.com/FedeOmoto/bignum
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels