refine agent update in mongo

Author: Jicheng Lu

src/Infrastructure/BotSharp.Abstraction/Agents/Enums/AgentField.cs

@@ -0,0 +1,13 @@
+namespace BotSharp.Abstraction.Agents.Enums;
+
+public enum AgentField
+{
+    All = 1,
+    Name,
+    Description,
+    IsPublic,
+    Instruction,
+    Function,
+    Template,
+    Response
+}

src/Infrastructure/BotSharp.Abstraction/Agents/IAgentService.cs

@@ -17,7 +17,7 @@ public interface IAgentService
 
     Task<Agent> GetAgent(string id);
     Task<bool> DeleteAgent(string id);
-    Task UpdateAgent(Agent agent);
+    Task UpdateAgent(Agent agent, AgentField updateField);
     Task UpdateAgentFromFile(string id);
     string GetDataDir();
     string GetAgentDataDir(string agentId);

src/Infrastructure/BotSharp.Abstraction/Repositories/IBotSharpRepository.cs

@@ -1,3 +1,4 @@
+using BotSharp.Abstraction.Agents.Enums;
 using BotSharp.Abstraction.Routing.Models;
 using BotSharp.Abstraction.Users.Models;
 
@@ -15,27 +16,32 @@ public interface IBotSharpRepository
     int Transaction<TTableInterface>(Action action);
     void Add<TTableInterface>(object entity);
 
+    #region User
     User GetUserByEmail(string email);
     void CreateUser(User user);
-    void UpdateAgent(Agent agent);
-
-    List<RoutingItem> CreateRoutingItems(List<RoutingItem> routingItems);
-    List<RoutingProfile> CreateRoutingProfiles(List<RoutingProfile> profiles);
-    void DeleteRoutingItems();
-    void DeleteRoutingProfiles();
+    #endregion
 
+    #region Agent
+    void UpdateAgent(Agent agent, AgentField field);
     Agent GetAgent(string agentId);
     List<string> GetAgentResponses(string agentId, string prefix, string intent);
+    string GetAgentTemplate(string agentId, string templateName);
+    #endregion
 
+    #region Conversation
     void CreateNewConversation(Conversation conversation);
     string GetConversationDialog(string conversationId);
     void UpdateConversationDialog(string conversationId, string dialogs);
-
     List<StateKeyValue> GetConversationStates(string conversationId);
     void UpdateConversationStates(string conversationId, List<StateKeyValue> states);
-
     Conversation GetConversation(string conversationId);
     List<Conversation> GetConversations(string userId);
+    #endregion
 
-    string GetAgentTemplate(string agentId, string templateName);
+    #region Routing
+    List<RoutingItem> CreateRoutingItems(List<RoutingItem> routingItems);
+    List<RoutingProfile> CreateRoutingProfiles(List<RoutingProfile> profiles);
+    void DeleteRoutingItems();
+    void DeleteRoutingProfiles();
+    #endregion    
 }

src/Infrastructure/BotSharp.Abstraction/Using.cs

@@ -5,4 +5,5 @@
 global using System.Threading.Tasks;
 global using System.ComponentModel.DataAnnotations;
 global using BotSharp.Abstraction.Agents.Models;
-global using BotSharp.Abstraction.Conversations.Models;
+global using BotSharp.Abstraction.Conversations.Models;
+global using BotSharp.Abstraction.Agents.Enums;

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.CreateAgent.cs

@@ -8,11 +8,9 @@ public partial class AgentService
 {
     public async Task<Agent> CreateAgent(Agent agent)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-
-        var agentRecord = (from a in db.Agents
-                     join ua in db.UserAgents on a.Id equals ua.AgentId
-                     join u in db.Users on ua.UserId equals u.Id
+        var agentRecord = (from a in _db.Agents
+                     join ua in _db.UserAgents on a.Id equals ua.AgentId
+                     join u in _db.Users on ua.UserId equals u.Id
                      where u.ExternalId == _user.Id && a.Name == agent.Name
                      select a).FirstOrDefault();
 
@@ -43,7 +41,7 @@ join u in db.Users on ua.UserId equals u.Id
                        .SetResponses(foundAgent.Responses);
         }
 
-        var user = db.Users.FirstOrDefault(x => x.ExternalId == _user.Id);
+        var user = _db.Users.FirstOrDefault(x => x.ExternalId == _user.Id);
         var userAgentRecord = new UserAgent
         {
             Id = Guid.NewGuid().ToString(),
@@ -53,10 +51,10 @@ join u in db.Users on ua.UserId equals u.Id
             UpdatedTime = DateTime.UtcNow
         };
 
-        db.Transaction<IBotSharpTable>(delegate
+        _db.Transaction<IBotSharpTable>(delegate
         {
-            db.Add<IBotSharpTable>(agentRecord);
-            db.Add<IBotSharpTable>(userAgentRecord);
+            _db.Add<IBotSharpTable>(agentRecord);
+            _db.Add<IBotSharpTable>(userAgentRecord);
         });
 
         return agentRecord;

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.GetAgents.cs

@@ -7,10 +7,9 @@ public partial class AgentService
 {
     public async Task<List<Agent>> GetAgents()
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-        var query = from a in db.Agents
-                    join ua in db.UserAgents on a.Id equals ua.AgentId
-                    join u in db.Users on ua.UserId equals u.Id
+        var query = from a in _db.Agents
+                    join ua in _db.UserAgents on a.Id equals ua.AgentId
+                    join u in _db.Users on ua.UserId equals u.Id
                     where ua.UserId == _user.Id || u.ExternalId == _user.Id || a.IsPublic
                     select a;
         return query.ToList();
@@ -21,8 +20,7 @@ join u in db.Users on ua.UserId equals u.Id
 #endif
     public async Task<Agent> GetAgent(string id)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-        var profile = db.GetAgent(id);
+        var profile = _db.GetAgent(id);
 
         var instructionFile = profile?.Instruction;
         if (instructionFile != null)

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.UpdateAgent.cs

@@ -6,44 +6,31 @@ namespace BotSharp.Core.Agents.Services;
 
 public partial class AgentService
 {
-    public async Task UpdateAgent(Agent agent)
+    public async Task UpdateAgent(Agent agent, AgentField updateField)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-
-        var record = (from a in db.Agents
-                      join ua in db.UserAgents on a.Id equals ua.AgentId
-                      join u in db.Users on ua.UserId equals u.Id
-                      where (ua.UserId == _user.Id || u.ExternalId == _user.Id) &&
-                        a.Id == agent.Id
-                      select a).FirstOrDefault();
+        if (agent == null || string.IsNullOrEmpty(agent.Id)) return;
 
+        var record = FindAgent(agent.Id);
         if (record == null) return;
 
-        record.Name = agent.Name;
-
-        if (!string.IsNullOrEmpty(agent.Description))
-            record.Description = agent.Description;
-
-        if (!string.IsNullOrEmpty(agent.Instruction))
-            record.Instruction = agent.Instruction;
-
-        if (!agent.Templates.IsNullOrEmpty())
-            record.Templates = agent.Templates;
-
-        if (!agent.Functions.IsNullOrEmpty())
-            record.Functions = agent.Functions;
-
-        if (!agent.Responses.IsNullOrEmpty())
-            record.Responses = agent.Responses;
-
-        db.UpdateAgent(record);
+        _db.UpdateAgent(record, updateField);
         await Task.CompletedTask;
     }
 
+    private Agent FindAgent(string agentId)
+    {
+        var record = (from a in _db.Agents
+                      join ua in _db.UserAgents on a.Id equals ua.AgentId
+                      join u in _db.Users on ua.UserId equals u.Id
+                      where (ua.UserId == _user.Id || u.ExternalId == _user.Id) &&
+                        a.Id == agentId
+                      select a).FirstOrDefault();
+        return record;
+    }
+
     public async Task UpdateAgentFromFile(string id)
     {
-        var db = _services.GetRequiredService<IBotSharpRepository>();
-        var agent = db.Agents?.FirstOrDefault(x => x.Id == id);
+        var agent = _db.Agents?.FirstOrDefault(x => x.Id == id);
 
         if (agent == null) return;
 
@@ -64,10 +51,9 @@ public async Task UpdateAgentFromFile(string id)
                        .SetFunctions(foundAgent.Functions)
                        .SetResponses(foundAgent.Responses);
 
-            db.UpdateAgent(clonedAgent);
+            _db.UpdateAgent(clonedAgent, AgentField.All);
         }
 
-
         await Task.CompletedTask;
     }
 

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.cs

@@ -1,23 +1,25 @@
 using BotSharp.Abstraction.Repositories;
-using Microsoft.Extensions.Logging;
 using System.IO;
 
 namespace BotSharp.Core.Agents.Services;
 
 public partial class AgentService : IAgentService
 {
     private readonly IServiceProvider _services;
+    private readonly IBotSharpRepository _db;
     private readonly ILogger _logger;
     private readonly IUserIdentity _user;
     private readonly AgentSettings _settings;
     private readonly JsonSerializerOptions _options;
 
-    public AgentService(IServiceProvider services, 
+    public AgentService(IServiceProvider services,
+        IBotSharpRepository db,
         ILogger<AgentService> logger, 
         IUserIdentity user, 
         AgentSettings settings)
     {
         _services = services;
+        _db = db;
         _logger = logger;
         _user = user;
         _settings = settings;

src/Infrastructure/BotSharp.Core/Repository/BotSharpDbContext.cs

@@ -1,3 +1,4 @@
+using BotSharp.Abstraction.Agents.Enums;
 using BotSharp.Abstraction.Agents.Models;
 using BotSharp.Abstraction.Repositories;
 using BotSharp.Abstraction.Routing.Models;
@@ -137,7 +138,7 @@ public User GetUserByEmail(string email)
         throw new NotImplementedException();
     }
 
-    public void UpdateAgent(Agent agent)
+    public void UpdateAgent(Agent agent, AgentField field)
     {
         throw new NotImplementedException();
     }