Skip to content

Commit 6cfbe40

Browse files
authored
Merge pull request #971 from visagang/features/vguruparan
Update webdriver code
2 parents 0ed8eca + 9f0995b commit 6cfbe40

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

src/Plugins/BotSharp.Plugin.WebDriver/Drivers/PlaywrightDriver/PlaywrightWebDriver.Screenshot.cs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
1-
using BotSharp.Abstraction.Browsing.Settings;
2-
31
namespace BotSharp.Plugin.WebDriver.Drivers.PlaywrightDriver;
42

53
public partial class PlaywrightWebDriver
64
{
75
public async Task<BrowserActionResult> ScreenshotAsync(MessageInfo message, string path)
86
{
97
var result = new BrowserActionResult();
10-
var _webDriver = _services.GetRequiredService<WebBrowsingSettings>();
11-
if (_webDriver.IsEnableScreenshot)
8+
if (_webBrowsingSettings.IsEnableScreenshot)
129
{
1310
await _instance.Wait(message.ContextId, waitNetworkIdle: false);
1411
var page = _instance.GetPage(message.ContextId);

src/Plugins/BotSharp.Plugin.WebDriver/Drivers/PlaywrightDriver/PlaywrightWebDriver.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,26 @@
11

2+
using BotSharp.Abstraction.Browsing.Settings;
3+
24
namespace BotSharp.Plugin.WebDriver.Drivers.PlaywrightDriver;
35

46
public partial class PlaywrightWebDriver : IWebBrowser
57
{
68
private IServiceProvider _services => _instance.Services;
79
private readonly PlaywrightInstance _instance;
810
private readonly ILogger _logger;
11+
private readonly WebBrowsingSettings _webBrowsingSettings;
912
public PlaywrightInstance Instance => _instance;
1013

1114
public Agent Agent => _agent;
1215
private Agent _agent;
1316

14-
public PlaywrightWebDriver(IServiceProvider services, PlaywrightInstance instance, ILogger<PlaywrightWebDriver> logger)
17+
public PlaywrightWebDriver(IServiceProvider services, PlaywrightInstance instance, ILogger<PlaywrightWebDriver> logger, WebBrowsingSettings webBrowsingSettings)
1518
{
1619
_instance = instance;
1720
_logger = logger;
1821
_instance.SetServiceProvider(services);
19-
}
22+
_webBrowsingSettings = webBrowsingSettings;
23+
}
2024

2125
public void SetAgent(Agent agent)
2226
{

src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebActionOnElementFn.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ public async Task<bool> Execute(RoleDialogModel message)
3434

3535
var conv = _services.GetRequiredService<IConversationService>();
3636

37-
var browser = _services.GetRequiredService<IWebBrowser>();
37+
var services = _services.CreateScope().ServiceProvider;
38+
var browser = services.GetRequiredService<IWebBrowser>();
3839
var webDriverService = _services.GetRequiredService<WebDriverService>();
3940
var msg = new MessageInfo
4041
{

src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebCloseBrowserFn.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ public async Task<bool> Execute(RoleDialogModel message)
1919
{
2020
var conv = _services.GetRequiredService<IConversationService>();
2121
var webDriverService = _services.GetRequiredService<WebDriverService>();
22-
var browser = _services.GetRequiredService<IWebBrowser>();
22+
var services = _services.CreateScope().ServiceProvider;
23+
var browser = services.GetRequiredService<IWebBrowser>();
2324
var msg = new MessageInfo
2425
{
2526
AgentId = message.CurrentAgentId,

src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebGoToPageFn.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ public async Task<bool> Execute(RoleDialogModel message)
3030

3131
var conv = _services.GetRequiredService<IConversationService>();
3232
var webDriverService = _services.GetRequiredService<WebDriverService>();
33-
var browser = _services.GetRequiredService<IWebBrowser>();
33+
var services = _services.CreateScope().ServiceProvider;
34+
var browser = services.GetRequiredService<IWebBrowser>();
3435
var msg = new MessageInfo
3536
{
3637
AgentId = message.CurrentAgentId,

src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebLocateElementFn.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ public async Task<bool> Execute(RoleDialogModel message)
2121
var conv = _services.GetRequiredService<IConversationService>();
2222
locatorArgs.Highlight = true;
2323

24-
var browser = _services.GetRequiredService<IWebBrowser>();
24+
var services = _services.CreateScope().ServiceProvider;
25+
var browser = services.GetRequiredService<IWebBrowser>();
2526
var webDriverService = _services.GetRequiredService<WebDriverService>();
2627
var msg = new MessageInfo
2728
{

0 commit comments

Comments
 (0)