Merge pull request #942 from iceljc/master

refine conv tags

Author: iceljc

src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationService.cs

@@ -13,7 +13,7 @@ public interface IConversationService
     Task<PagedItems<Conversation>> GetConversations(ConversationFilter filter);
     Task<Conversation> UpdateConversationTitle(string id, string title);
     Task<Conversation> UpdateConversationTitleAlias(string id, string titleAlias);
-    Task<bool> UpdateConversationTags(string conversationId, List<string> tags);
+    Task<bool> UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags);
     Task<bool> UpdateConversationMessage(string conversationId, UpdateMessageRequest request);
     Task<List<Conversation>> GetLastConversations();
     Task<List<string>> GetIdleConversations(int batchSize, int messageLimit, int bufferHours, IEnumerable<string> excludeAgentIds);

src/Infrastructure/BotSharp.Abstraction/Repositories/IBotSharpRepository.cs

@@ -132,7 +132,7 @@ void UpdateConversationTitle(string conversationId, string title)
         => throw new NotImplementedException();
     void UpdateConversationTitleAlias(string conversationId, string titleAlias)
         => throw new NotImplementedException();
-    bool UpdateConversationTags(string conversationId, List<string> tags)
+    bool UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags)
         => throw new NotImplementedException();
     bool AppendConversationTags(string conversationId, List<string> tags)
         => throw new NotImplementedException();

src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationService.cs

@@ -59,10 +59,10 @@ public async Task<Conversation> UpdateConversationTitleAlias(string id, string t
         return conversation;
     }
 
-    public async Task<bool> UpdateConversationTags(string conversationId, List<string> tags)
+    public async Task<bool> UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags)
     {
         var db = _services.GetRequiredService<IBotSharpRepository>();
-        return db.UpdateConversationTags(conversationId, tags);
+        return db.UpdateConversationTags(conversationId, toAddTags, toDeleteTags);
     }
 
     public async Task<bool> UpdateConversationMessage(string conversationId, UpdateMessageRequest request)

src/Infrastructure/BotSharp.Core/Repository/FileRepository/FileRepository.Conversation.cs

@@ -158,7 +158,7 @@ public void UpdateConversationTitleAlias(string conversationId, string titleAlia
         }
     }
 
-    public bool UpdateConversationTags(string conversationId, List<string> tags)
+    public bool UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags)
     {
         if (string.IsNullOrEmpty(conversationId)) return false;
 
@@ -170,7 +170,11 @@ public bool UpdateConversationTags(string conversationId, List<string> tags)
 
         var json = File.ReadAllText(convFile);
         var conv = JsonSerializer.Deserialize<Conversation>(json, _options);
-        conv.Tags = tags ?? new();
+
+        var tags = conv.Tags ?? [];
+        tags = tags.Concat(toAddTags).Distinct().ToList();
+        conv.Tags = tags.Where(x => !toDeleteTags.Contains(x, StringComparer.OrdinalIgnoreCase)).ToList();
+
         conv.UpdatedTime = DateTime.UtcNow;
         File.WriteAllText(convFile, JsonSerializer.Serialize(conv, _options));
         return true;

src/Infrastructure/BotSharp.OpenAPI/Controllers/ConversationController.cs

@@ -255,7 +255,7 @@ public async Task<bool> UpdateConversationTitleAlias([FromRoute] string conversa
     public async Task<bool> UpdateConversationTags([FromRoute] string conversationId, [FromBody] UpdateConversationRequest request)
     {
         var conv = _services.GetRequiredService<IConversationService>();
-        return await conv.UpdateConversationTags(conversationId, request.Tags);
+        return await conv.UpdateConversationTags(conversationId, request.ToAddTags, request.ToDeleteTags);
     }
 
     [HttpPut("/conversation/{conversationId}/update-message")]

src/Infrastructure/BotSharp.OpenAPI/ViewModels/Conversations/Request/UpdateConversationRequest.cs

@@ -2,5 +2,6 @@ namespace BotSharp.OpenAPI.ViewModels.Conversations;
 
 public class UpdateConversationRequest
 {
-    public List<string> Tags { get; set; } = [];
+    public List<string> ToAddTags { get; set; } = [];
+    public List<string> ToDeleteTags { get; set; } = [];
 }

src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs

@@ -134,13 +134,20 @@ public void UpdateConversationTitleAlias(string conversationId, string titleAlia
         _dc.Conversations.UpdateOne(filterConv, updateConv);
     }
 
-    public bool UpdateConversationTags(string conversationId, List<string> tags)
+    public bool UpdateConversationTags(string conversationId, List<string> toAddTags, List<string> toDeleteTags)
     {
         if (string.IsNullOrEmpty(conversationId)) return false;
 
         var filter = Builders<ConversationDocument>.Filter.Eq(x => x.Id, conversationId);
+        var conv = _dc.Conversations.Find(filter).FirstOrDefault();
+        if (conv == null) return false;
+
+        var tags = conv.Tags ?? [];
+        tags = tags.Concat(toAddTags).Distinct().ToList();
+        tags = tags.Where(x => !toDeleteTags.Contains(x, StringComparer.OrdinalIgnoreCase)).ToList();
+
         var update = Builders<ConversationDocument>.Update
-                                                   .Set(x => x.Tags, tags ?? new())
+                                                   .Set(x => x.Tags, tags)
                                                    .Set(x => x.UpdatedTime, DateTime.UtcNow);
 
         var res = _dc.Conversations.UpdateOne(filter, update);