Merge pull request #809 from iceljc/master

refine agent knowledge base

Author: iceljc

src/Infrastructure/BotSharp.Abstraction/Agents/Models/Agent.cs

@@ -155,6 +155,7 @@ public static Agent Clone(Agent agent)
             Profiles = agent.Profiles,
             RoutingRules = agent.RoutingRules,
             LlmConfig = agent.LlmConfig,
+            KnowledgeBases = agent.KnowledgeBases,
             CreatedDateTime = agent.CreatedDateTime,
             UpdatedDateTime = agent.UpdatedDateTime,
         };
@@ -168,43 +169,49 @@ public Agent SetInstruction(string instruction)
 
     public Agent SetChannelInstructions(List<ChannelInstruction> instructions)
     {
-        ChannelInstructions = instructions ?? new List<ChannelInstruction>();
+        ChannelInstructions = instructions ?? [];
         return this;
     }
 
     public Agent SetTemplates(List<AgentTemplate> templates)
     {
-        Templates = templates ?? new List<AgentTemplate>();
+        Templates = templates ?? [];
         return this;
     }
 
     public Agent SetTasks(List<AgentTask> tasks)
     {
-        Tasks = tasks ?? new List<AgentTask>();
+        Tasks = tasks ?? [];
         return this;
     }
 
     public Agent SetFunctions(List<FunctionDef> functions)
     {
-        Functions = functions ?? new List<FunctionDef>();
+        Functions = functions ?? [];
         return this;
     }
 
     public Agent SetSamples(List<string> samples)
     {
-        Samples = samples ?? new List<string>();
+        Samples = samples ?? [];
         return this;
     }
 
     public Agent SetUtilities(List<AgentUtility> utilities)
     {
-        Utilities = utilities ?? new List<AgentUtility>();
+        Utilities = utilities ?? [];
+        return this;
+    }
+
+    public Agent SetKnowledgeBases(List<AgentKnowledgeBase> knowledgeBases)
+    {
+        knowledgeBases = knowledgeBases ?? [];
         return this;
     }
 
     public Agent SetResponses(List<AgentResponse> responses)
     {
-        Responses = responses ?? new List<AgentResponse>(); ;
+        Responses = responses ?? [];
         return this;
     }
 
@@ -252,13 +259,13 @@ public Agent SetAgentType(string type)
 
     public Agent SetProfiles(List<string> profiles)
     {
-        Profiles = profiles ?? new List<string>();
+        Profiles = profiles ?? [];
         return this;
     }
 
     public Agent SetRoutingRules(List<RoutingRule> rules)
     {
-        RoutingRules = rules ?? new List<RoutingRule>();
+        RoutingRules = rules ?? [];
         return this;
     }
 

src/Infrastructure/BotSharp.Abstraction/Agents/Models/AgentKnowledgeBase.cs

@@ -2,17 +2,19 @@ namespace BotSharp.Abstraction.Agents.Models;
 
 public class AgentKnowledgeBase
 {
-    public string? Name { get; set; }
+    public string Name { get; set; }
+    public string Type { get; set; }
     public bool Disabled { get; set; }
 
     public AgentKnowledgeBase()
     {
 
     }
 
-    public AgentKnowledgeBase(string name, bool enabled)
+    public AgentKnowledgeBase(string name, string type, bool enabled)
     {
         Name = name;
+        Type = type;
         Disabled = enabled;
     }
 

src/Infrastructure/BotSharp.Abstraction/Knowledges/IKnowledgeService.cs

@@ -9,7 +9,7 @@ public interface IKnowledgeService
     Task<bool> ExistVectorCollection(string collectionName);
     Task<bool> CreateVectorCollection(string collectionName, string collectionType, int dimension, string provider, string model);
     Task<bool> DeleteVectorCollection(string collectionName);
-    Task<IEnumerable<string>> GetVectorCollections(string type);
+    Task<IEnumerable<VectorCollectionConfig>> GetVectorCollections(string? type = null);
     Task<IEnumerable<VectorSearchResult>> SearchVectorKnowledge(string query, string collectionName, VectorSearchOptions options);
     Task<StringIdPagedItems<VectorSearchResult>> GetPagedVectorCollectionData(string collectionName, VectorFilter filter);
     Task<bool> DeleteVectorCollectionData(string collectionName, string id);

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.UpdateAgent.cs

@@ -103,6 +103,7 @@ public async Task<string> UpdateAgentFromFile(string id)
                        .SetResponses(foundAgent.Responses)
                        .SetSamples(foundAgent.Samples)
                        .SetUtilities(foundAgent.Utilities)
+                       .SetKnowledgeBases(foundAgent.KnowledgeBases)
                        .SetLlmConfig(foundAgent.LlmConfig);
 
             _db.UpdateAgent(clonedAgent, AgentField.All);

src/Infrastructure/BotSharp.OpenAPI/Controllers/AgentController.cs

@@ -10,7 +10,10 @@ public class AgentController : ControllerBase
     private readonly IUserIdentity _user;
     private readonly IServiceProvider _services;
 
-    public AgentController(IAgentService agentService, IUserIdentity user, IServiceProvider services)
+    public AgentController(
+        IAgentService agentService,
+        IUserIdentity user,
+        IServiceProvider services)
     {
         _agentService = agentService;
         _user = user;

src/Infrastructure/BotSharp.OpenAPI/Controllers/KnowledgeBaseController.cs

@@ -26,9 +26,10 @@ public async Task<bool> ExistVectorCollection([FromRoute] string collection)
     }
 
     [HttpGet("knowledge/vector/collections")]
-    public async Task<IEnumerable<string>> GetVectorCollections([FromQuery] string type)
+    public async Task<IEnumerable<VectorCollectionConfigViewModel>> GetVectorCollections([FromQuery] string? type = null)
     {
-        return await _knowledgeService.GetVectorCollections(type);
+        var collections = await _knowledgeService.GetVectorCollections(type);
+        return collections.Select(x => VectorCollectionConfigViewModel.From(x));
     }
 
     [HttpPost("knowledge/vector/create-collection")]

src/Infrastructure/BotSharp.OpenAPI/ViewModels/Agents/AgentCreationModel.cs

@@ -1,6 +1,5 @@
 using BotSharp.Abstraction.Agents.Models;
 using BotSharp.Abstraction.Functions.Models;
-using BotSharp.Abstraction.Routing.Models;
 
 namespace BotSharp.OpenAPI.ViewModels.Agents;
 
@@ -55,6 +54,7 @@ public class AgentCreationModel
 
     public List<AgentUtility> Utilities { get; set; } = new();
     public List<RoutingRuleUpdateModel> RoutingRules { get; set; } = new();
+    public List<AgentKnowledgeBase> KnowledgeBases { get; set; } = new();
     public AgentLlmConfig? LlmConfig { get; set; }
 
     public Agent ToAgent()
@@ -76,8 +76,9 @@ public Agent ToAgent()
             MergeUtility = MergeUtility,
             MaxMessageCount = MaxMessageCount,
             Profiles = Profiles,
-            RoutingRules = RoutingRules?.Select(x => RoutingRuleUpdateModel.ToDomainElement(x))?.ToList() ?? new List<RoutingRule>(),
-            LlmConfig = LlmConfig
+            LlmConfig = LlmConfig,
+            KnowledgeBases = KnowledgeBases,
+            RoutingRules = RoutingRules?.Select(x => RoutingRuleUpdateModel.ToDomainElement(x))?.ToList() ?? [],
         };
     }
 }

src/Infrastructure/BotSharp.OpenAPI/ViewModels/Knowledges/VectorCollectionConfigViewModel.cs

@@ -0,0 +1,17 @@
+using BotSharp.Abstraction.VectorStorage.Models;
+
+namespace BotSharp.OpenAPI.ViewModels.Knowledges;
+
+public class VectorCollectionConfigViewModel : VectorCollectionConfig
+{
+    public static VectorCollectionConfigViewModel From(VectorCollectionConfig model)
+    {
+        return new VectorCollectionConfigViewModel
+        {
+            Name = model.Name,
+            Type = model.Type,
+            VectorStore = model.VectorStore,
+            TextEmbedding = model.TextEmbedding
+        };
+    }
+}

src/Plugins/BotSharp.Plugin.KnowledgeBase/Services/KnowledgeService.Vector.cs

@@ -69,25 +69,25 @@ public async Task<bool> CreateVectorCollection(string collectionName, string col
         }
     }
 
-    public async Task<IEnumerable<string>> GetVectorCollections(string type)
+    public async Task<IEnumerable<VectorCollectionConfig>> GetVectorCollections(string? type = null)
     {
         try
         {
             var db = _services.GetRequiredService<IBotSharpRepository>();
-            var collectionNames = db.GetKnowledgeCollectionConfigs(new VectorCollectionConfigFilter
+            var configs = db.GetKnowledgeCollectionConfigs(new VectorCollectionConfigFilter
             {
-                CollectionTypes = new[] { type },
-                VectorStroageProviders = new[] { _settings.VectorDb.Provider }
-            }).Select(x => x.Name).ToList();
+                CollectionTypes = !string.IsNullOrEmpty(type) ? [type] : null,
+                VectorStroageProviders = [_settings.VectorDb.Provider]
+            }).ToList();
 
             var vectorDb = GetVectorDb();
-            var vectorCollections = await vectorDb.GetCollections();
-            return vectorCollections.Where(x => collectionNames.Contains(x));
+            var dbCollections = await vectorDb.GetCollections();
+            return configs.Where(x => dbCollections.Contains(x.Name));
         }
         catch (Exception ex)
         {
             _logger.LogWarning($"Error when getting vector db collections. {ex.Message}\r\n{ex.InnerException}");
-            return Enumerable.Empty<string>();
+            return Enumerable.Empty<VectorCollectionConfig>();
         }
     }
 

src/Plugins/BotSharp.Plugin.MongoStorage/Models/AgentKnowledgeBaseMongoElement.cs

@@ -5,13 +5,16 @@ namespace BotSharp.Plugin.MongoStorage.Models;
 public class AgentKnowledgeBaseMongoElement
 {
     public string Name { get; set; }
+    public string Type { get; set; }
     public bool Disabled { get; set; }
+
     public static AgentKnowledgeBaseMongoElement ToMongoElement(AgentKnowledgeBase knowledgeBase)
     {
         return new AgentKnowledgeBaseMongoElement
         {
-            Name = knowledgeBase.Name ?? string.Empty,
-            Disabled = knowledgeBase.Disabled,
+            Name = knowledgeBase.Name,
+            Type = knowledgeBase.Type,
+            Disabled = knowledgeBase.Disabled
         };
     }
 
@@ -20,6 +23,7 @@ public static AgentKnowledgeBase ToDomainElement(AgentKnowledgeBaseMongoElement
         return new AgentKnowledgeBase
         {
             Name = knowledgeBase.Name,
+            Type = knowledgeBase.Type,
             Disabled = knowledgeBase.Disabled
         };
     }