Merge pull request #933 from visagang/features/vguruparan

Update timeout for web driver logic to fetch from appSettings

Author: Oceania2018

src/Infrastructure/BotSharp.Abstraction/Browsing/Settings/WebBrowsingSettings.cs

@@ -4,4 +4,6 @@ public class WebBrowsingSettings
 {
     public string Driver { get; set; } = "Playwright";
     public bool Headless { get; set; }
+    // Default timeout in milliseconds
+    public float DefaultTimeout { get; set; } = 30000;
 }

src/Plugins/BotSharp.Plugin.WebDriver/Functions/GoToPageFn.cs

@@ -1,3 +1,5 @@
+using BotSharp.Abstraction.Browsing.Settings;
+
 namespace BotSharp.Plugin.WebDriver.Functions;
 
 public class GoToPageFn : IFunctionCallback
@@ -25,15 +27,16 @@ public async Task<bool> Execute(RoleDialogModel message)
         var url = webDriverService.ReplaceToken(args.Url);
 
         url = url.Replace("https://https://", "https://");
-
+        var _webDriver = _services.GetRequiredService<WebBrowsingSettings>();
         var result = await _browser.GoToPage(new MessageInfo
         {
             AgentId = message.CurrentAgentId,
             ContextId = convService.ConversationId,
             MessageId = message.MessageId
         }, new PageActionArgs
         {
-            Url = url
+            Url = url,
+            Timeout = _webDriver.DefaultTimeout
         });
         message.Content = result.IsSuccess ? $"Page {url} is open." : $"Page {url} open failed. {result.Message}";
 

src/Plugins/BotSharp.Plugin.WebDriver/Functions/OpenBrowserFn.cs

@@ -26,7 +26,7 @@ public async Task<bool> Execute(RoleDialogModel message)
 
         var webDriverService = _services.GetRequiredService<WebDriverService>();
         var url = webDriverService.ReplaceToken(args.Url);
-
+        var _webDriver = _services.GetRequiredService<WebBrowsingSettings>();
         url = url.Replace("https://https://", "https://");
         var msgInfo = new MessageInfo
         {
@@ -40,7 +40,8 @@ public async Task<bool> Execute(RoleDialogModel message)
         });
         result = await _browser.GoToPage(msgInfo, new PageActionArgs
         {
-            Url = url
+            Url = url,
+            Timeout = _webDriver.DefaultTimeout
         });
 
         if (result.IsSuccess)

src/Plugins/BotSharp.Plugin.WebDriver/UtilFunctions/UtilWebGoToPageFn.cs

@@ -1,3 +1,5 @@
+using BotSharp.Abstraction.Browsing.Settings;
+
 namespace BotSharp.Plugin.WebDriver.UtilFunctions;
 
 public class UtilWebGoToPageFn : IFunctionCallback
@@ -21,6 +23,8 @@ public async Task<bool> Execute(RoleDialogModel message)
         {
             PropertyNamingPolicy = JsonNamingPolicy.CamelCase
         });
+        var _webDriver = _services.GetRequiredService<WebBrowsingSettings>();
+        args.Timeout = _webDriver.DefaultTimeout;
         args.WaitForNetworkIdle = false;
         args.WaitTime = 5;
         args.OpenNewTab = true;