Cleanup and renamed internal functions of NDArray.Indexing.*

Author: Nucs

src/NumSharp.Core/Indexing/np.nonzero.cs

@@ -12,19 +12,15 @@ namespace NumSharp
 {
     public static partial class np
     {
-
         /// <summary>
-        /// Return the indices of the elements that are non-zero.
-        /// 
-        /// Returns a tuple of arrays, one for each dimension of a, containing the indices of the non-zero elements in that dimension.The values in a are always tested and returned in row-major, C-style order.
-        ///
-        /// To group the indices by element, rather than dimension, use argwhere, which returns a row for each non-zero element.
+        ///     Return the indices of the elements that are non-zero.
+        ///     Returns a tuple of arrays, one for each dimension of a, containing the indices of the non-zero elements in that dimension.The values in a are always tested and returned in row-major, C-style order.
+        ///     To group the indices by element, rather than dimension, use argwhere, which returns a row for each non-zero element.
         /// </summary>
-        /// <param name="a"></param>
-        /// <returns></returns>
+        /// <param name="a">Input array.</param>
+        /// <returns>Indices of elements that are non-zero.</returns>
+        /// <remarks>https://docs.scipy.org/doc/numpy/reference/generated/numpy.nonzero.html</remarks>
         public static NDArray<int>[] nonzero(in NDArray a)
             => a.TensorEngine.NonZero(a);
-
-
     }
 }

src/NumSharp.Core/Selection/NDArray.Indexing.Masking.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Runtime.CompilerServices;
 using NumSharp.Backends;
@@ -16,9 +17,10 @@ public partial class NDArray
         /// <remarks>https://docs.scipy.org/doc/numpy-1.17.0/user/basics.indexing.html</remarks>
         /// <exception cref="IndexOutOfRangeException">When one of the indices exceeds limits.</exception>
         /// <exception cref="ArgumentException">indices must be of Int type (byte, u/short, u/int, u/long).</exception>
+        [SuppressMessage("ReSharper", "CoVariantArrayConversion")]
         public NDArray this[NDArray<bool> mask]
         {
-            get => retrieve_indices(this, np.nonzero(mask), null, true);
+            get => FetchIndices(this, np.nonzero(mask), null, true);
             set
             {
                 throw new NotImplementedException("Setter is not implemented yet");