Skip to content

Commit 36a5bc3

Browse files
authored
Use https://github.com/MetOffice/mule instead of old location (#6879)
* Use https://github.com/MetOffice/mule instead of old location. * Remove Mule monkey patch. * Bump cache.
1 parent ace09fc commit 36a5bc3

File tree

6 files changed

+7
-14
lines changed

6 files changed

+7
-14
lines changed

.github/workflows/benchmarks_run.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
IRIS_TEST_DATA_PATH: benchmarks/iris-test-data
6767
IRIS_TEST_DATA_VERSION: "2.28"
6868
# Lets us manually bump the cache to rebuild
69-
ENV_CACHE_BUILD: "0"
69+
ENV_CACHE_BUILD: "1"
7070
TEST_DATA_CACHE_BUILD: "2"
7171

7272
steps:

.github/workflows/benchmarks_validate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323

2424
env:
2525
# Lets us manually bump the cache to rebuild
26-
ENV_CACHE_BUILD: "0"
26+
ENV_CACHE_BUILD: "1"
2727

2828
steps:
2929
- name: Checkout repo

benchmarks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ accordingly.
5757
used to generate benchmark test objects/files; see
5858
[Data generation](#data-generation). The benchmark runner sets this
5959
automatically, but will defer to any value already set in the shell. Note that
60-
[Mule](https://github.com/metomi/mule) will be automatically installed into
60+
[Mule](https://github.com/MetOffice/mule) will be automatically installed into
6161
this environment, and sometimes
6262
[iris-test-data](https://github.com/SciTools/iris-test-data) (see
6363
`OVERRIDE_TEST_DATA_REPOSITORY`).

benchmarks/benchmarks/generate_data/um_files.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,12 @@ def _create_um_files(
2222
from tempfile import NamedTemporaryFile
2323

2424
from mule import ArrayDataProvider, Field3, FieldsFile
25-
import mule.ff
2625
from mule.pp import fields_to_pp_file
2726
import numpy as np
2827

2928
from iris import load_cube
3029
from iris import save as save_cube
3130

32-
def to_bytes_patch(self, field):
33-
data = field.get_data()
34-
dtype = mule.ff._DATA_DTYPES[self.WORD_SIZE][field.lbuser1]
35-
data = data.astype(dtype)
36-
return data.tobytes(), data.size
37-
38-
# TODO: remove this patch when fixed in mule, see https://github.com/MetOffice/simulation-systems/discussions/389
39-
mule.ff._WriteFFOperatorUnpacked.to_bytes = to_bytes_patch
40-
4131
template = {
4232
"fixed_length_header": {"dataset_type": 3, "grid_staggering": 3},
4333
"integer_constants": {

benchmarks/bm_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def clone_resource(name: str, clone_source: str) -> Path:
9999
return clone_dir
100100

101101
echo("Installing Mule into data generation environment ...")
102-
mule_dir = clone_resource("mule", "https://github.com/metomi/mule.git")
102+
mule_dir = clone_resource("mule", "https://github.com/MetOffice/mule.git")
103103
_subprocess_runner(
104104
[
105105
str(data_gen_python),

docs/src/whatsnew/latest.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ This document explains the changes made to Iris for this release
9393
#. `@trexfeathers`_ adapted ``test_OceanSigmaZFactory`` for NumPy 2.4 - only
9494
0-dimensional arrays can now be converted to scalars. (:pull:`6876`)
9595

96+
#. `@trexfeathers`_ updated benchmarking to source Mule from its new home:
97+
https://github.com/MetOffice/mule . (:pull:`6879`)
98+
9699

97100
.. comment
98101
Whatsnew author names (@github name) in alphabetical order. Note that,

0 commit comments

Comments
 (0)