add pygrep hooks (#141)

Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>

Author: stephenworsley

.pre-commit-config.yaml

@@ -102,4 +102,29 @@ repos:
     hooks:
       - id: numpydoc-validation
         types: [file, python]
-        exclude: 'src\/mo_pack\/tests'
+        exclude: 'src\/mo_pack\/tests'
+
+- repo: https://github.com/pre-commit/pygrep-hooks
+  rev: v1.10.0
+  hooks:
+    - id: python-check-blanket-noqa
+      # Enforce that all noqa annotations always occur with specific codes.
+    - id: python-check-blanket-type-ignore
+      # Enforce that "# type: ignore" annotations always occur with specific codes.
+    - id: python-check-mock-methods
+      # Prevent common mistakes of assert mck.not_called(), assert
+      # mck.called_once_with(...) and mck.assert_called.
+    - id: python-no-eval
+      # A quick check for the eval() built-in function
+    - id: python-no-log-warn
+      # A quick check for the deprecated .warn() method of python loggers
+    - id: python-use-type-annotations
+      # Enforce that python3.6+ type annotations are used instead of type comments
+    - id: rst-backticks
+      # Detect common mistake of using single backticks when writing rst.
+    - id: rst-directive-colons
+      # Detect mistake of rst directive not ending with double colon.
+    - id: rst-inline-touching-normal
+      # Detect mistake of inline code touching normal text in rst.
+    - id: text-unicode-replacement-char
+      # Forbid files which have a UTF-8 Unicode replacement character.

pyproject.toml

@@ -123,8 +123,6 @@ exclude = [
 
 [tool.repo-review]
 ignore = [
-    # https://learn.scientific-python.org/development/guides/style/#PC170
-    "PC170",  # Uses PyGrep hooks
     # https://learn.scientific-python.org/development/guides/style/#PC180
     "PC180",  # Uses prettier
     # https://learn.scientific-python.org/development/guides/packaging-simple/#PY004